Type-safe safeValue #58

Activity

1. nighca commented on Nov 23, 2021

   

   nighca

   on Nov 23, 2021

   CollaboratorAuthor

   More actions

   Related discussion: https://github.com/qbox/horn/pull/340#discussion_r699824181
2. nighca commented on Nov 23, 2021

   

   nighca

   on Nov 23, 2021

   Last edited by nighca

   CollaboratorAuthor

   More actions

   Some ideas:

   1. Auto type inference by validators

   const state = new FieldState<string | null>('').validators(notNull) // safeValue: string

   It's hard, maybe impossible

   2. Generic type passing with validator

   const state = new FieldState<string | null>('').validators<string>(notNull) // safeValue: string

   3. Generic type passing with constructor

   const state = new FieldState<string | null, string>('').validators(notNull) // safeValue: string

   4. Type assertion while read safeValue

   const state = new FieldState<string | null>('').validators(notNull)
   const safeValue = state.safeValue! // string

   This is not real "type-safe"..
3. nighca

   self-assigned this

   on Apr 18, 2022
4. nighca

   added

   enhancementNew feature or requestNew feature or request

   on Apr 18, 2022
5. mattleonowicz commented on May 11, 2022

   

   mattleonowicz

   on May 11, 2022

   Contributor

   More actions

   One thing to consider: should this value be defined and available even when validators return errors?
   If not, then 2. makes sense.

   But if this value is always defined, regardless of latest validation result, then I would suggest not linking the safeType with validators as in 2.
6. nighca commented on May 12, 2022

   

   nighca

   on May 12, 2022

   CollaboratorAuthor

   More actions

   One thing to consider: should this value be defined and available even when validators return errors?

   Accessing safe-value will throw if currently validation not passed.

   @computed get safeValue() {
     if (!this.validated || this.hasError) throw new Error('TODO')
     return this.value
   }

   👍React with 👍1Reacted by Mateusz Leonowicz