Skip to content

Commit 9224c67

Browse files
kiukchungfacebook-github-bot
authored andcommitted
(torchx/pipelines) Retire support for OSS pipelines; kfp and airflow (#1119)
Summary: Pull Request resolved: #1119 Virtually no usages on github (https://github.com/search?q=torchx.pipelines.kfp&type=code) other than references from forks of torchx. Retiring support to reduce maintainer burden and quicker/lighter CI. Reviewed By: ethanbwaite Differential Revision: D82579476
1 parent 3f9e19e commit 9224c67

29 files changed

+1
-1547
lines changed

.github/workflows/kfp-integration-tests.yaml

Lines changed: 0 additions & 34 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ lintrunner init
3939
lintrunner -a
4040
```
4141

42-
## Integration Tests
43-
44-
See the [KFP integration test](scripts/kfpint.py) file for more details on setup
45-
and running them.
46-
4742
## License
4843
By contributing to TorchX, you agree that your contributions will be licensed
4944
under the LICENSE file in the root directory of this source tree.

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ pip install torchx
5555
# install torchx sdk and CLI -- all dependencies
5656
pip install "torchx[dev]"
5757

58-
# install torchx kubeflow pipelines (kfp) support
59-
pip install "torchx[kfp]"
60-
6158
# install torchx Kubernetes / Volcano support
6259
pip install "torchx[kubernetes]"
6360

dev-requirements.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ google-cloud-logging==3.10.0
1212
google-cloud-runtimeconfig==0.34.0
1313
hydra-core
1414
ipython
15-
kfp==1.8.22
16-
# pin protobuf to the version that is required by kfp
17-
protobuf==3.20.3
1815
mlflow-skinny
1916
moto~=5.0.8
2017
pyre-extensions
@@ -45,4 +42,3 @@ grpcio==1.62.1
4542
grpcio-status==1.48.1
4643
googleapis-common-protos==1.63.0
4744
google-api-core==2.18.0
48-
protobuf==3.20.3 # kfp==1.8.22 needs protobuf < 4

docs/source/basics.rst

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -141,29 +141,6 @@ There are two ways to access runners in TorchX:
141141
See :ref:`Schedulers` for a list of schedulers that the runner can
142142
launch apps to.
143143

144-
Pipeline Adapters
145-
~~~~~~~~~~~~~~~~~~~~~~
146-
While runners launch components as standalone jobs, ``torchx.pipelines``
147-
makes it possible to plug components into an ML pipeline/workflow. For a
148-
specific target pipeline platform (e.g. kubeflow pipelines), TorchX
149-
defines an adapter that converts a TorchX app spec to whatever the
150-
"stage" representation is in the target platform. For instance,
151-
``torchx.pipelines.kfp`` adapter for kubeflow pipelines converts an
152-
app spec to a ``kfp.ContainerOp`` (or more accurately, a kfp "component spec" yaml).
153-
154-
155-
In most cases an app spec would map to a "stage" (or node) in a pipeline.
156-
However advanced components, especially those that have a mini control flow
157-
of its own (e.g. HPO), may map to a "sub-pipeline" or an "inline-pipeline".
158-
The exact semantics of how these advanced components map to the pipeline
159-
is dependent on the target pipeline platform. For example, if the
160-
pipeline DSL allows dynamically adding stages to a pipeline from an upstream
161-
stage, then TorchX may take advantage of such feature to "inline" the
162-
sub-pipeline to the main pipeline. TorchX generally tries its best to adapt
163-
app specs to the **most canonical** representation in the target pipeline platform.
164-
165-
See :ref:`Pipelines` for a list of supported pipeline platforms.
166-
167144
Runtime
168145
~~~~~~~~
169146
.. important:: ``torchx.runtime`` is by no means is a requirement to use TorchX.

docs/source/conf.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def handle_item(fieldarg, content):
341341
code_url = f"https://github.com/pytorch/torchx/archive/refs/heads/{notebook_version}.tar.gz"
342342

343343
first_notebook_cell = f"""
344-
!pip install torchx[kfp]
344+
!pip install torchx
345345
!wget --no-clobber {code_url}
346346
!tar xf {notebook_version}.tar.gz --strip-components=1
347347
@@ -351,7 +351,6 @@ def handle_item(fieldarg, content):
351351
sphinx_gallery_conf = {
352352
"examples_dirs": [
353353
"../../torchx/examples/apps",
354-
"../../torchx/examples/pipelines",
355354
],
356355
"gallery_dirs": [
357356
"examples_apps",

docs/source/index.rst

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,6 @@ Works With
9191

9292
schedulers/fb/*
9393

94-
.. _Pipelines:
95-
.. toctree::
96-
:maxdepth: 1
97-
:caption: Pipelines
98-
99-
pipelines/kfp
100-
pipelines/airflow.md
101-
10294
.. fbcode::
10395

10496
.. toctree::
@@ -116,7 +108,6 @@ Examples
116108
:caption: Examples
117109

118110
examples_apps/index
119-
examples_pipelines/index
120111

121112

122113
Components Library

docs/source/pipelines/airflow.md

Lines changed: 0 additions & 104 deletions
This file was deleted.

docs/source/pipelines/kfp.rst

Lines changed: 0 additions & 24 deletions
This file was deleted.
-4.42 MB
Binary file not shown.

0 commit comments

Comments
 (0)