DeprecatedNotAFuture #677
Closed
DeprecatedNotAFuture #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Jul 29, 2025
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! ghstack-source-id: 299181648 Pull Request resolved: #677
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
This was referenced Jul 29, 2025
Closed
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 1, 2025
This moves around the PythonTask logic so that ProcMesh and Alloc can be directly returned as python objects while preserving the same user-facing API. It introduces a `DeprecatedNotAFuture` class to polyfill get()/await to ProcMesh and Alloc so that existing code works as unchanged but raises a warning saying it is ok to delete the get()/await. Pull Request resolved: #677 ghstack-source-id: 300228621 @exported-using-ghexport Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/)
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 2, 2025
This moves around the PythonTask logic so that ProcMesh and Alloc can be directly returned as python objects while preserving the same user-facing API. It introduces a `DeprecatedNotAFuture` class to polyfill get()/await to ProcMesh and Alloc so that existing code works as unchanged but raises a warning saying it is ok to delete the get()/await. Pull Request resolved: #677 ghstack-source-id: 300327773 @exported-using-ghexport Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)!
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 2, 2025
This moves around the PythonTask logic so that ProcMesh and Alloc can be directly returned as python objects while preserving the same user-facing API. It introduces a `DeprecatedNotAFuture` class to polyfill get()/await to ProcMesh and Alloc so that existing code works as unchanged but raises a warning saying it is ok to delete the get()/await. Pull Request resolved: #677 ghstack-source-id: 300330427 @exported-using-ghexport Differential Revision: [D79143853](https://our.internmc.facebook.com/intern/diff/D79143853/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79143853/)!
|
This pull request was exported from Phabricator. Differential Revision: D79143853 |
|
This pull request has been merged in fa2c327. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D79143853
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!