Skip to content

Commit 0baa412

Browse files
pzhan9facebook-github-bot
authored andcommitted
Migrate to PythonActorMesh and PythonActorMeshRef (#557)
Summary: This diff swaps `_ActorMeshRefImpl` with `PythonActorMesh[Ref]`. The swap itself should be straightforward since `PythonActorMesh[Ref]` should be drop-in replacements for `_ActorMeshRefImpl`. Most of the complexity in this diff is from how I tried to add a toggle between them, just in case there is any bugs with `PythonActorMesh[Ref]`, so we can quickly switch back to `_ActorMeshRefImpl`. What I did is: 1. Add wrapper classes `EitherPyActorMesh[Ref]`, whose underlying type can be either `PythonActorMesh[Ref]` or `_ActorMeshRefImpl`; 2. a env var `USE_STANDIN_ACTOR_MESH` is used to which one would be used when instantiating `EitherPyActorMesh[Ref]`. The landing of this diff would mean all Python-side mesh API calls should go through Rust-side's `cast` code path, except several usages of `ActorIdRef`. Differential Revision: D78355743
1 parent 2d91d14 commit 0baa412

File tree

6 files changed

+342
-94
lines changed

6 files changed

+342
-94
lines changed

0 commit comments

Comments
 (0)