-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: make relative working directory absolute #10611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
finswimmer
wants to merge
1
commit into
python-poetry:main
Choose a base branch
from
finswimmer:full-directory-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideAdds a working_directory property to the Application, ensures it is resolved to an absolute path when provided via the --directory option, and updates tests to verify this behavior. Sequence diagram for resolving working directory to absolute pathsequenceDiagram
participant IO
participant Application
IO->>Application: option("directory")
Application->>Application: ensure_path(option, is_directory=True)
Application->>Application: .resolve() (make absolute)
Application->>Application: set _working_directory
Class diagram for updated Application classclassDiagram
class Application {
+project_directory: Path
+working_directory: Path
+poetry: Poetry
_project_directory: Path
_working_directory: Path
_default_definition(): Definition
_configure_global_options(io: IO): None
}
Application : +working_directory
Application : +project_directory
Application : +poetry
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
1969505 to
83512a8
Compare
83512a8 to
cbb81f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #10541
Resolves: #10287
Summary by Sourcery
Resolve the application's working directory to an absolute path when a relative --directory option is provided and expose it via a new property, with corresponding test updates.
New Features:
Enhancements:
Tests: