refactor: centralize python installation path logic via PoetryPythonPathProvider

Author: finswimmer

src/poetry/console/commands/python/list.py

@@ -8,9 +8,9 @@
 from poetry.core.constraints.version import parse_constraint
 from poetry.core.version.exceptions import InvalidVersionError
 
-from poetry.config.config import Config
 from poetry.console.commands.command import Command
 from poetry.utils.env.python import Python
+from poetry.utils.env.python.providers import PoetryPythonPathProvider
 
 
 if TYPE_CHECKING:
@@ -84,7 +84,7 @@ def handle(self) -> int:
         )
 
         implementations = {"cpython": "CPython", "pypy": "PyPy"}
-        python_installation_path = Config.create().python_installation_dir
+        python_installation_path = PoetryPythonPathProvider.base_installation_dir()
 
         row_count = 0
 

src/poetry/console/commands/python/remove.py

@@ -10,8 +10,8 @@
 from poetry.core.constraints.version.version import Version
 from poetry.core.version.exceptions import InvalidVersionError
 
-from poetry.config.config import Config
 from poetry.console.commands.command import Command
+from poetry.utils.env.python.providers import PoetryPythonPathProvider
 
 
 if TYPE_CHECKING:
@@ -63,7 +63,9 @@ def remove_python_installation(request: str, implementation: str, io: IO) -> int
             return 1
 
         request_title = f"<c1>{request}</> (<b>{implementation}</>)"
-        path = Config.create().python_installation_dir / f"{implementation}@{version}"
+        path = PoetryPythonPathProvider.installation_dir(
+            version=version, implementation=implementation
+        )
 
         if path.exists():
             if io.is_verbose():

src/poetry/utils/env/python/installer.py

@@ -10,10 +10,10 @@
 
 from poetry.core.constraints.version import Version
 
-from poetry.config.config import Config
 from poetry.console.exceptions import ConsoleMessage
 from poetry.console.exceptions import PoetryRuntimeError
 from poetry.utils.env.python import Python
+from poetry.utils.env.python.providers import PoetryPythonPathProvider
 
 
 if TYPE_CHECKING:
@@ -46,7 +46,8 @@ class PythonInstaller:
     implementation: Literal["cpython", "pypy"] = dataclasses.field(default="cpython")
     free_threaded: bool = dataclasses.field(default=False)
     installation_directory: Path = dataclasses.field(
-        init=False, default_factory=lambda: Config.create().python_installation_dir
+        init=False,
+        default_factory=lambda: PoetryPythonPathProvider.base_installation_dir(),
     )
 
     @property

src/poetry/utils/env/python/providers.py

@@ -41,9 +41,13 @@ def find_python_by_name(cls, name: str) -> findpython.PythonVersion | None:
 
 @dataclasses.dataclass
 class PoetryPythonPathProvider(PathProvider):  # type: ignore[misc]
+    @classmethod
+    def base_installation_dir(cls) -> Path:
+        return Config.create().python_installation_dir
+
     @classmethod
     def installation_dir(cls, version: Version, implementation: str) -> Path:
-        return Config.create().python_installation_dir / f"{implementation}@{version}"
+        return cls.base_installation_dir() / f"{implementation}@{version}"
 
     @classmethod
     def _make_bin_paths(cls, base: Path | None = None) -> list[Path]:
@@ -55,7 +59,7 @@ def _make_bin_paths(cls, base: Path | None = None) -> list[Path]:
         # If both versions exist, the first one is preferred.
         # However, sometimes (especially for free-threaded Python),
         # only the second version exists!
-        install_dir = base or Config.create().python_installation_dir
+        install_dir = base or cls.base_installation_dir()
         if WINDOWS and not sysconfig.get_platform().startswith("mingw"):
             # On Windows Python executables are top level.
             # (Only in virtualenvs, they are in the Scripts directory.)