⚠️ Nightly upstream-dev CI failed ⚠️

[github-actions]

Workflow Run URL

Python 3.12 Test Summary

xarray/tests/test_computation.py::test_fix: NotImplementedError: xarray objects are not yet supported in the `out` argument for ufuncs. As an alternative, consider explicitly converting xarray objects to NumPy arrays (e.g., with `.values`).

[keewis]

Looks like this is a side-effect of numpy/numpy#29951. The difference within numpy.fix is:

# before
res = nx.asanyarray(nx.ceil(x, out=out))
# after
res = nx.ceil(x, out=... if out is None else out)

I assume before we would get a numpy array from that line, which is later passed to np.floor's out parameter, and then wrapped by __array_wrap__ to get back a DataArray object.

With the new changes np.ceil returns a DataArray, which does not support being passed as out, which is where this fails.

Not sure how to best fix that, seeing as we were supporting this function through __array_wrap__. numpy.fix could possibly be supported through __array_function__ (as far as I remember, we don't need to support every function dispatched through that protocol), but we don't have the general infrastructure in place.