Merge branch 'release/3.1.1'

Author: hbredin

doc/source/changelog.rst

@@ -2,6 +2,13 @@
 Changelog
 #########
 
+Version 3.1.1 (2025-02-07)
+~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+- fix: should_prune() takes no argument
+- fix: make `Optimizer.best_loss`` return infinity with no trial
+
+
 Version 3.1.0 (2025-01-12)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
 

pyannote/pipeline/optimizer.py

@@ -76,7 +76,7 @@ class Optimizer:
         Seed value for the random number generator of the sampler.
         Defaults to no seed.
     average_case : `bool`, optional
-        Optimize for average case (default). 
+        Optimize for average case (default).
         Set to False to optimize for worst case.
     """
 
@@ -148,7 +148,12 @@ def __init__(
     @property
     def best_loss(self) -> float:
         """Return best loss so far"""
-        return self.study_.best_value
+        try:
+            best_value = self.study_.best_value
+        except Exception:
+            direction: int = 1 if self.pipeline.get_direction() == "minimize" else -1
+            best_value = direction * np.inf
+        return best_value
 
     @property
     def best_params(self) -> dict:
@@ -255,8 +260,8 @@ def objective(trial: Trial) -> float:
                     continue
 
                 trial.report(np.mean(losses) if metric is None else abs(metric), i)
-                if trial.should_prune(i):
-                    raise optuna.structs.TrialPruned()
+                if trial.should_prune():
+                    raise optuna.TrialPruned()
 
             if show_progress != False:
                 progress_bar.close()