fix overlapped DER and its test

(the test passed with an incorrect metric because the hypothesis contained no overlap)

Author: FrenchKrab

src/pyannote/metrics/diarization.py

@@ -676,8 +676,8 @@ class OverlappedDiarizationErrorRate(BaseMetric):
     def __init__(self, collar: float = 0.0):
         super().__init__()
 
-        self.der_ovl = DiarizationErrorRate(collar=collar, skip_overlap=False)
-        self.der_nonovl = DiarizationErrorRate(collar=collar, skip_overlap=False)
+        self.der_ovl = IdentificationErrorRate(collar=collar, skip_overlap=False)
+        self.der_nonovl = IdentificationErrorRate(collar=collar, skip_overlap=False)
 
     @classmethod
     def metric_components(cls) -> MetricComponents:

tests/test_diarization.py

@@ -51,24 +51,37 @@ def hypothesis():
     return hypothesis
 
 
-def test_ovl_der(reference_with_overlap, hypothesis):
+@pytest.fixture
+def hypothesis_overlap():
+    hypothesis = Annotation()
+    hypothesis[Segment(2, 13)] = "a"
+    hypothesis[Segment(10, 14)] = "d"
+    hypothesis[Segment(14, 24)] = "b"
+    hypothesis[Segment(22, 38)] = "c"
+    hypothesis[Segment(36, 40)] = "d"
+    return hypothesis
+
+
+def test_ovl_der(reference_with_overlap, hypothesis_overlap: Annotation):
     der_ovl = OverlappedDiarizationErrorRate()
     der_regular = DiarizationErrorRate()
 
-    error_rate_ovl = der_ovl(reference_with_overlap, hypothesis)
-    error_rate_regular = der_regular(reference_with_overlap, hypothesis)
+    error_rate_ovl = der_ovl(reference_with_overlap, hypothesis_overlap)
+    error_rate_regular = der_regular(reference_with_overlap, hypothesis_overlap)
 
     npt.assert_almost_equal(error_rate_ovl, error_rate_regular, decimal=7)
 
 
-def test_ovl_der_components(reference_with_overlap, hypothesis):
+def test_ovl_der_components(reference_with_overlap, hypothesis_overlap):
     for collar in [0.0, 0.1, 0.5]:
         der_ovl = OverlappedDiarizationErrorRate(collar=collar)
         der_regular = DiarizationErrorRate(collar=collar)
 
-        comp_ovl: Details = der_ovl(reference_with_overlap, hypothesis, detailed=True)
+        comp_ovl: Details = der_ovl(
+            reference_with_overlap, hypothesis_overlap, detailed=True
+        )
         comp_regular: Details = der_regular(
-            reference_with_overlap, hypothesis, detailed=True
+            reference_with_overlap, hypothesis_overlap, detailed=True
         )
 
         print(comp_ovl)