Skip to content

PusherOptions.readVersionFromProperties android.os.strictmode.DiskReadViolation #288

@wbervoets

Description

@wbervoets

What is the issue?

When enabling StrictMode on Android the PusherOptions.readVersionFromProperties generates a DiskReadViolation because it reads from the file system from the UI thread.

Isn't it possible to let the build system generate a BuildConfig.PUSHER_VERSION file that is used instead so we don't need to read in the file when constructing PusherOptions() ?

...


CC @pusher/mobile

Activity

daniel-shuy

daniel-shuy commented on Oct 29, 2022

@daniel-shuy

Created a PR (#349) which should fix this

wbervoets

wbervoets commented on Feb 10, 2023

@wbervoets
Author

any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @danielrbrowne@wbervoets@daniel-shuy@britneycodes

      Issue actions

        PusherOptions.readVersionFromProperties android.os.strictmode.DiskReadViolation · Issue #288 · pusher/pusher-websocket-java