Skip to content

Commit 101241f

Browse files
authored
Merge pull request #284 from pusher/dev-fix-set-ssl-parameters-2
Fix websocket issue with pre android sdk 24 devices
2 parents d5e60c5 + 2b96533 commit 101241f

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/main/java/com/pusher/client/channel/impl/PrivateEncryptedChannelImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ private PusherEvent decryptMessage(String message) {
185185
encryptedReceivedData.getCiphertext(),
186186
encryptedReceivedData.getNonce());
187187

188-
receivedMessage.replace("data", decryptedData);
188+
receivedMessage.put("data", decryptedData);
189189

190190
return new PusherEvent(receivedMessage);
191191
}

src/main/java/com/pusher/client/connection/websocket/WebSocketClientWrapper.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
import javax.net.ssl.SSLContext;
1010
import javax.net.ssl.SSLException;
11+
import javax.net.ssl.SSLParameters;
1112
import javax.net.ssl.SSLSocketFactory;
1213

1314
import org.java_websocket.client.WebSocketClient;
@@ -89,4 +90,14 @@ public void onError(final Exception ex) {
8990
public void removeWebSocketListener() {
9091
webSocketListener = null;
9192
}
93+
94+
@Override
95+
protected void onSetSSLParameters(SSLParameters sslParameters) {
96+
// https://github.com/TooTallNate/Java-WebSocket/wiki/No-such-method-error-setEndpointIdentificationAlgorithm
97+
try {
98+
super.onSetSSLParameters(sslParameters);
99+
} catch (NoSuchMethodError error) {
100+
// if this is being called on an android device pre-24 this api isn't available
101+
}
102+
}
92103
}

0 commit comments

Comments
 (0)