Skip to content

Commit 2df81c5

Browse files
committed
Remove per-process globals from per-thread context.
1 parent 828bf50 commit 2df81c5

File tree

3 files changed

+8
-17
lines changed

3 files changed

+8
-17
lines changed

src/node.cc

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,24 +97,18 @@ extern char **environ;
9797
// use the variables as they were being used before.
9898
#define check_tick_watcher NODE_VAR(check_tick_watcher)
9999
#define code_symbol NODE_VAR(code_symbol)
100-
#define debug_port NODE_VAR(debug_port)
101-
#define debug_wait_connect NODE_VAR(debug_wait_connect)
102100
#define emit_symbol NODE_VAR(emit_symbol)
103101
#define errno_symbol NODE_VAR(errno_symbol)
104102
#define errpath_symbol NODE_VAR(errpath_symbol)
105-
#define eval_string NODE_VAR(eval_string)
106103
#define gc_check NODE_VAR(gc_check)
107104
#define gc_idle NODE_VAR(gc_idle)
108105
#define gc_timer NODE_VAR(gc_timer)
109106
#define getbuf NODE_VAR(getbuf)
110107
#define heap_total_symbol NODE_VAR(heap_total_symbol)
111108
#define heap_used_symbol NODE_VAR(heap_used_symbol)
112109
#define listeners_symbol NODE_VAR(listeners_symbol)
113-
#define max_stack_size NODE_VAR(max_stack_size)
114110
#define need_tick_cb NODE_VAR(need_tick_cb)
115-
#define option_end_index NODE_VAR(option_end_index)
116111
#define prepare_tick_watcher NODE_VAR(prepare_tick_watcher)
117-
#define print_eval NODE_VAR(print_eval)
118112
#define process NODE_VAR(process)
119113
#define rss_symbol NODE_VAR(rss_symbol)
120114
#define syscall_symbol NODE_VAR(syscall_symbol)
@@ -123,7 +117,6 @@ extern char **environ;
123117
#define tick_time_head NODE_VAR(tick_time_head)
124118
#define tick_times NODE_VAR(tick_times)
125119
#define uncaught_exception_symbol NODE_VAR(uncaught_exception_symbol)
126-
#define use_debug_agent NODE_VAR(use_debug_agent)
127120
#define use_npn NODE_VAR(use_npn)
128121
#define use_sni NODE_VAR(use_sni)
129122
#define uncaught_exception_counter NODE_VAR(uncaught_exception_counter)
@@ -136,11 +129,17 @@ extern char **environ;
136129

137130
namespace node {
138131

132+
static int option_end_index;
133+
static unsigned long max_stack_size;
134+
static unsigned short debug_port = 5858;
135+
static bool debug_wait_connect;
136+
static bool use_debug_agent;
137+
static const char* eval_string;
138+
static bool print_eval;
139139

140140

141-
#define TICK_TIME(n) tick_times[(tick_time_head - (n)) % RPM_SAMPLES]
142-
143141

142+
#define TICK_TIME(n) tick_times[(tick_time_head - (n)) % RPM_SAMPLES]
144143

145144
static void CheckStatus(uv_timer_t* watcher, int status);
146145

src/node_vars.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace node {
1212

1313
void globals_init(struct globals* g) {
1414
memset(g, 0, sizeof(struct globals));
15-
g->debug_port = 5858;
1615

1716
#ifdef OPENSSL_NPN_NEGOTIATED
1817
g->use_npn = true;

src/node_vars.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,6 @@ struct globals {
3131
v8::Persistent<v8::String> listeners_symbol;
3232
v8::Persistent<v8::String> uncaught_exception_symbol;
3333
v8::Persistent<v8::String> emit_symbol;
34-
bool print_eval;
35-
char *eval_string;
36-
int option_end_index;
37-
bool use_debug_agent;
38-
bool debug_wait_connect;
39-
int debug_port;
40-
int max_stack_size;
4134
uv_check_t check_tick_watcher;
4235
uv_prepare_t prepare_tick_watcher;
4336
uv_idle_t tick_spinner;

0 commit comments

Comments
 (0)