Skip to content

Simplify has_unsupported_isle_instructions now that skip block is minimal #60

@avrabe

Description

@avrabe

Context

After PR #53, has_unsupported_isle_instructions only checks for Instruction::Unknown(_). The function still does recursive block traversal, but it's now equivalent to the simpler has_unknown_instructions helper.

TODO

Consider consolidating:

  • Remove has_unsupported_isle_instructions and has_unsupported_isle_instructions_in_block
  • Replace all call sites with has_unknown_instructions (which already exists and does the same flat check)
  • Or: make has_unknown_instructions recursive like the unsupported version (it currently only checks top-level instructions)

Files

  • loom-core/src/lib.rs: Both functions defined around line 6600, used in ~15 optimization passes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions