-
Notifications
You must be signed in to change notification settings - Fork 97
Description
Bug description
fseq_fpu_yield is currently calculated as (fpss_fpu_issues / snitch_fseq_offloads) / fpss_fpu_rel_issues:
snitch_cluster/util/trace/gen_trace.py
Lines 750 to 753 in 699d404
| 'fseq_fpu_yield': | |
| safe_div( | |
| safe_div(seg['fpss_fpu_issues'], seg['snitch_fseq_offloads']), | |
| fpss_fpu_rel_issues), |
fpss_fpu_rel_issues is in turn calculated as fpss_fpu_issues / fpss_issues:
snitch_cluster/util/trace/gen_trace.py
Lines 736 to 737 in 699d404
| fpss_fpu_rel_issues = safe_div(seg['fpss_fpu_issues'], | |
| seg['fpss_issues']) |
It follows that fseq_fpu_yield = fpss_issues / snitch_fseq_offloads, which equals fseq_yield by definition:
snitch_cluster/util/trace/gen_trace.py
Lines 748 to 749 in 699d404
| 'fseq_yield': | |
| safe_div(seg['fpss_issues'], seg['snitch_fseq_offloads']), |
Solution
I believe the original intent was for fseq_fpu_yield to represent the FREP yield related to FPU proper instructions only. Then we could simply calculate fseq_fpu_yield = fpss_fpu_issues / snitch_fseq_offloads. Perhaps even better, we would rectify snitch_fseq_offloads to count only instructions destined to the FPU proper.
I'm not sure of the usefulness of this metric altogether, so perhaps we could also just remove the duplicate fseq_fpu_yield.