UIExplorer: transforms not working with position #232

Activity

1. aleclarson commented on Mar 18, 2019

   

   aleclarson

   on Mar 18, 2019

   Collaborator

   More actions

   This will be fixed when #234 is merged.

   🎉React with 🎉1Reacted by smallnewer
2. aleclarson

   added

   bug

   on Mar 18, 2019
3. smallnewer commented on Mar 19, 2019

   

   smallnewer

   on Mar 19, 2019

   Author

   More actions

   Thanks^_^
   It's also not working with #234 . Maybe I did something wrong?

   My steps

   1. download code from https://github.com/ptmt/react-native-macos/tree/fa28701469188d2b757af84934e13014dacbed9d, which is last commit in Various fixes to RCTView props #234
   2. delete node_modules/react-native-macos/React in my demo project，and copy React(downloaded) to my demo project
   3. build and run ，transform also not working after resize the window。

   I'm sure it's #234 code.

   key codes:

       render() {
           return (
               <TouchableOpacity 
                   style={{position:"absolute", right:100,width:200,height:200,transform:[{translateY:101}],backgroundColor:"red"}}>     
               </TouchableOpacity>
           )
       }
4. smallnewer commented on Mar 19, 2019

   

   smallnewer

   on Mar 19, 2019

   Author

   More actions

   After I delete some code at RCTView.m，It working right:

   //  if (!CGSizeEqualToSize(self.bounds.size, oldSize)) {
       [self.layer setNeedsDisplay];
   //  }

   I don't know if it's appropriate to make such a change.
5. aleclarson commented on Mar 19, 2019

   

   aleclarson

   on Mar 19, 2019

   Last edited by aleclarson

   Collaborator

   More actions

   Nice find!

   When the frame is updated (eg: by resizing the window), the transform needs to be reapplied.

   I've added a new commit to #234, which you should try and let me know if it works. 572a274

   If it doesn't work, we can call [self.layer setNeedsDisplay] when _transform is not an identity transform.
6. smallnewer commented on Mar 20, 2019

   

   smallnewer

   on Mar 20, 2019

   Author

   More actions

   It works right . Thanks @aleclarson ! 👍

   🎉React with 🎉1Reacted by Alec Larson