Skip to content

Commit d3d0481

Browse files
committed
address comment: we dont deal with it
1 parent b26bd78 commit d3d0481

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎lib/LANraragi/Model/Plugins.pm‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,8 @@ sub has_old_style_params (%params) {
322322

323323
# Install a plugin from a registry whose index has been refreshed and cached.
324324
# namespace, registry_id, version are required to identify the plugin to install.
325-
# TODO(REVIEW) what if the signature of the plugin changes from one version to the next, or across provenance, in a way which is incompatible?
326-
# because uninstall plugin keeps configuration, this will require thought...
325+
# LRR assumes managed plugins are hash-style, and doesn't handle signature
326+
# changes from one plugin version to another.
327327
sub install_plugin {
328328
my ( $namespace, $redis, $registry_id, $version ) = @_;
329329

0 commit comments

Comments
 (0)