diff --git a/langserver/completion.go b/langserver/completion.go index 63472818..d73380fc 100644 --- a/langserver/completion.go +++ b/langserver/completion.go @@ -34,7 +34,7 @@ import ( func (s *server) Completion(ctx context.Context, params *protocol.CompletionParams) (ret *protocol.CompletionList, err error) { location, err := s.cache.Find(¶ms.TextDocumentPositionParams) if err != nil { - return nil, nil + return nil, err } ret = &protocol.CompletionList{} diff --git a/langserver/definition.go b/langserver/definition.go index 02f669e4..802497fa 100644 --- a/langserver/definition.go +++ b/langserver/definition.go @@ -21,13 +21,13 @@ import ( ) // Definition is required by the protocol.Server interface. -func (s *server) Definition(ctx context.Context, params *protocol.DefinitionParams) ([]protocol.Location, error) { +func (s *server) Definition(_ context.Context, params *protocol.DefinitionParams) ([]protocol.Location, error) { location, err := s.cache.Find(¶ms.TextDocumentPositionParams) if err != nil { - return nil, nil + return nil, err } - defs := []protocol.Location{} + var defs []protocol.Location switch n := location.Node.(type) { // nolint: gocritic case *promql.VectorSelector: diff --git a/langserver/hover.go b/langserver/hover.go index b16c352a..1c241211 100644 --- a/langserver/hover.go +++ b/langserver/hover.go @@ -50,13 +50,13 @@ func initializeFunctionDocumentation() http.FileSystem { func (s *server) Hover(ctx context.Context, params *protocol.HoverParams) (*protocol.Hover, error) { location, err := s.cache.Find(¶ms.TextDocumentPositionParams) if err != nil || location.Node == nil { - return nil, nil + return nil, err } markdown := s.nodeToDocMarkdown(ctx, location) hoverRange, err := getEditRange(location, "") if err != nil { - return nil, nil + return nil, err } return &protocol.Hover{ diff --git a/langserver/signature.go b/langserver/signature.go index 2d9aedc6..9d13b258 100644 --- a/langserver/signature.go +++ b/langserver/signature.go @@ -22,20 +22,20 @@ import ( ) // SignatureHelp is required by the protocol.Server interface. -func (s *server) SignatureHelp(ctx context.Context, params *protocol.SignatureHelpParams) (*protocol.SignatureHelp, error) { +func (s *server) SignatureHelp(_ context.Context, params *protocol.SignatureHelpParams) (*protocol.SignatureHelp, error) { location, err := s.cache.Find(¶ms.TextDocumentPositionParams) if err != nil { - return nil, nil + return nil, err } call, ok := location.Node.(*promql.Call) if !ok { - return nil, nil + return nil, errors.New("no node find for the given query") } signature, err := getSignature(call.Func.Name) if err != nil { - return nil, nil + return nil, err } activeParameter := 0.