fix(tenantresource): ensure original map is not modified in prepareAdditionalMetadata (#1572)

yehlo · renovate[bot] · web-flow · commit 67b5c3e880ab · 2025-08-18T11:48:01.000+02:00
* fix(tenantresource): avoid side effects by copying metadata map instead of returning reference Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> * chore(deps): update github/codeql-action digest to 4474150 (#1569) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> chore(tenantresource): make linter happy Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> * chore(deps): update all-ci-updates (#1571) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v5 (#1577) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency pre-commit/pre-commit-hooks to v6 (#1573) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github/codeql-action digest to c6dcdfa (#1575) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
diff --git a/controllers/resources/processor.go b/controllers/resources/processor.go
@@ -40,7 +40,13 @@ func prepareAdditionalMetadata(m map[string]string) map[string]string {
 		return make(map[string]string)
 	}
 
-	return m
+	// we need to create a new map to avoid modifying the original one
+	copied := make(map[string]string, len(m))
+	for k, v := range m {
+		copied[k] = v
+	}
+
+	return copied
 }
 
 func (r *Processor) HandlePruning(ctx context.Context, current, desired sets.Set[string]) (updateStatus bool) {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,13 @@ func prepareAdditionalMetadata(m map[string]string) map[string]string {`
`40`	`40`	`return make(map[string]string)`
`41`	`41`	`}`
`42`	`42`
`43`		`- return m`
	`43`	`+ // we need to create a new map to avoid modifying the original one`
	`44`	`+ copied := make(map[string]string, len(m))`
	`45`	`+ for k, v := range m {`
	`46`	`+ copied[k] = v`
	`47`	`+ }`
	`48`	`+`
	`49`	`+ return copied`
`44`	`50`	`}`
`45`	`51`
`46`	`52`	`func (r *Processor) HandlePruning(ctx context.Context, current, desired sets.Set[string]) (updateStatus bool) {`