fix(grid): restore spacegroup member initialization#427
Open
CV-GPhL wants to merge 1 commit into
Open
Conversation
Restores the initialization of GridMeta::spacegroup = nullptr that was inadvertently removed in PR project-gemmi#418. This fixes undefined behavior when the space group pointer is accessed before being explicitly set. Part of comprehensive fix for initialization removals introduced in Doxygen documentation PR series (project-gemmi#413-project-gemmi#422).
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the initialization of
GridMeta::spacegroup = nullptrthat wasinadvertently removed during the Doxygen documentation PR series (#413-#422).
This uninitialized pointer member could cause undefined behavior if accessed
before being explicitly set.
Related to the partial fix in commit 2c1b0c5, which addressed the same issue
in metadata.hpp and small.hpp.