SedRegex: add support for custom delimiters #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will stop being a constant in a following commit.
We want to make the delimiters set configurable, but this is hard with pluginRegexp because the regex is baked into the docstring.
Via a new "plugins.SedRegex.delimiters" setting. This defaults to all symbols to match the existing behaviour. Fixes #1610.
jlu5
force-pushed
the
sedregex-configurable-delimiters
branch
from
c3f4129 to
e814cfe
Compare
progval
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via a new "plugins.SedRegex.delimiters" setting. This defaults to all symbols to match the existing behaviour.
Note that there is some refactoring needed to support this. Since PluginsRegexp expects the regexp to be static (baked into the docstring), I've changed this to be a regular plugin with a custom doPrivmsg handler that does most of the work.