Skip to content

Commit d043bea

Browse files
committed
plugins/Google: modernize translate API call
Use urlencode and HTTPS
1 parent 029421e commit d043bea

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

plugins/Google/plugin.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,14 @@ def _translate(self, sourceLang, targetLang, text):
6262

6363
text = utils.web.urlquote(text)
6464

65-
result = utils.web.getUrlFd('http://translate.googleapis.com/translate_a/single'
66-
'?client=gtx&dt=t&sl=%s&tl=%s&q='
67-
'%s' % (sourceLang, targetLang, text),
68-
headers).read().decode('utf8')
69-
70-
while ',,' in result:
71-
result = result.replace(',,', ',null,')
72-
while '[,' in result:
73-
result = result.replace('[,', '[')
65+
url = 'https://translate.googleapis.com/translate_a/single?' + \
66+
utils.web.urlencode({
67+
'client': 'gtx',
68+
'dt': 't',
69+
'sl': sourceLang,
70+
'tl': targetLang,
71+
'q': text})
72+
result = utils.web.getUrlFd(url, headers).read().decode('utf8')
7473
data = json.loads(result)
7574

7675
try:

0 commit comments

Comments
 (0)