Skip to content

Commit b8eda93

Browse files
committed
plugins Q-Z: remove minisix uses and unused builtin imports
1 parent 439d35c commit b8eda93

File tree

9 files changed

+20
-60
lines changed

9 files changed

+20
-60
lines changed

plugins/QuoteGrabs/plugin.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import supybot.conf as conf
3939
import supybot.utils as utils
4040
from supybot.commands import *
41-
import supybot.utils.minisix as minisix
4241
import supybot.ircmsgs as ircmsgs
4342
import supybot.plugins as plugins
4443
import supybot.ircutils as ircutils
@@ -88,14 +87,10 @@ def p(s1, s2):
8887
return self.dbs[filename]
8988
if os.path.exists(filename):
9089
db = sqlite3.connect(filename)
91-
if minisix.PY2:
92-
db.text_factory = str
9390
db.create_function('nickeq', 2, p)
9491
self.dbs[filename] = db
9592
return db
9693
db = sqlite3.connect(filename)
97-
if minisix.PY2:
98-
db.text_factory = str
9994
db.create_function('nickeq', 2, p)
10095
self.dbs[filename] = db
10196
cursor = db.cursor()

plugins/RSS/plugin.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import supybot.utils as utils
4747
import supybot.world as world
4848
from supybot.commands import *
49-
import supybot.utils.minisix as minisix
5049
import supybot.ircmsgs as ircmsgs
5150
import supybot.ircutils as ircutils
5251
import supybot.registry as registry
@@ -59,10 +58,7 @@
5958
else:
6059
INIT_DELAY = 10
6160

62-
if minisix.PY2:
63-
from urllib2 import ProxyHandler
64-
else:
65-
from urllib.request import ProxyHandler
61+
from urllib.request import ProxyHandler
6662

6763
from .config import register_feed_config
6864

plugins/Scheduler/plugin.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
import time
3232
import os
33-
import math
33+
import pickle
3434
import shutil
3535
import tempfile
3636

@@ -43,9 +43,6 @@
4343
_ = PluginInternationalization('Scheduler')
4444
import supybot.world as world
4545

46-
import supybot.utils.minisix as minisix
47-
pickle = minisix.pickle
48-
4946
datadir = conf.supybot.directories.data()
5047
filename = conf.supybot.directories.data.dirize('Scheduler.pickle')
5148

plugins/Seen/plugin.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import supybot.ircdb as ircdb
4141
from supybot.commands import *
4242
import supybot.irclib as irclib
43-
import supybot.utils.minisix as minisix
4443
import supybot.ircmsgs as ircmsgs
4544
import supybot.plugins as plugins
4645
import supybot.ircutils as ircutils
@@ -204,8 +203,6 @@ def _seen(self, irc, channel, name, any=False):
204203
nick, channel,
205204
utils.timeElapsed(time.time()-when))
206205
if self.registryValue('showLastMessage', channel, irc.network):
207-
if minisix.PY2:
208-
said = said.decode('utf8')
209206
reply = _('%s: %s') % (reply, said)
210207
irc.reply(reply)
211208
elif len(results) > 1:

plugins/String/plugin.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,12 @@
3030
###
3131

3232
import re
33-
import sys
34-
import types
3533
import codecs
36-
import base64
3734
import binascii
3835
import unicodedata
3936

4037
import supybot.utils as utils
4138
from supybot.commands import *
42-
import supybot.utils.minisix as minisix
4339
import supybot.plugins as plugins
4440
import supybot.commands as commands
4541
import supybot.ircutils as ircutils
@@ -120,9 +116,7 @@ def encode(self, irc, msg, args, encoding, text):
120116
text = codecs.getencoder('base64_codec')(text)[0].decode()
121117

122118
# Change result into a string
123-
if minisix.PY2 and isinstance(text, unicode):
124-
text = text.encode('utf-8')
125-
elif minisix.PY3 and isinstance(text, bytes):
119+
if isinstance(text, bytes):
126120
text = text.decode()
127121

128122
if encoding in ('base64', 'base64_codec'):
@@ -152,7 +146,7 @@ def decode(self, irc, msg, args, encoding, text):
152146
decoder = codecs.getdecoder(encoding)
153147
except LookupError:
154148
irc.errorInvalid(_('encoding'), encoding)
155-
if minisix.PY3 and not isinstance(text, bytes):
149+
if not isinstance(text, bytes):
156150
text = text.encode()
157151
try:
158152
text = decoder(text)[0]
@@ -163,9 +157,7 @@ def decode(self, irc, msg, args, encoding, text):
163157
return
164158

165159
# Change result into a string
166-
if minisix.PY2 and isinstance(text, unicode):
167-
text = text.encode('utf-8')
168-
elif minisix.PY3 and isinstance(text, bytes):
160+
if isinstance(text, bytes):
169161
try:
170162
text = text.decode()
171163
except UnicodeDecodeError:

plugins/Topic/plugin.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
import os
3232
import re
33+
import pickle
3334
import random
3435
import shutil
3536
import tempfile
@@ -48,9 +49,6 @@
4849

4950
import supybot.ircdb as ircdb
5051

51-
import supybot.utils.minisix as minisix
52-
pickle = minisix.pickle
53-
5452
def canChangeTopic(irc, msg, args, state):
5553
assert not state.channel
5654
callConverter('channel', irc, msg, args, state)

plugins/URL/plugin.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import supybot.conf as conf
3636
import supybot.utils as utils
3737
from supybot.commands import *
38-
import supybot.utils.minisix as minisix
3938
import supybot.plugins as plugins
4039
import supybot.ircmsgs as ircmsgs
4140
import supybot.ircutils as ircutils
@@ -116,7 +115,7 @@ def last(self, irc, msg, args, channel, optlist):
116115
f = None
117116
nolimit = False
118117
for (option, arg) in optlist:
119-
if isinstance(arg, minisix.string_types):
118+
if isinstance(arg, str):
120119
arg = arg.lower()
121120
if option == 'nolimit':
122121
nolimit = True

plugins/Unix/plugin.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
import supybot.conf as conf
5050
import supybot.utils as utils
5151
from supybot.commands import *
52-
import supybot.utils.minisix as minisix
5352
import supybot.plugins as plugins
5453
import supybot.ircutils as ircutils
5554
import supybot.registry as registry
@@ -237,12 +236,8 @@ def fortune(self, irc, msg, args):
237236
'not available.'), Raise=True)
238237
(out, err) = inst.communicate()
239238
inst.wait()
240-
if minisix.PY3:
241-
lines = [i.decode('utf-8').rstrip() for i in out.splitlines()]
242-
lines = list(map(str, lines))
243-
else:
244-
lines = out.splitlines()
245-
lines = list(map(str.rstrip, lines))
239+
lines = [i.decode('utf-8').rstrip() for i in out.splitlines()]
240+
lines = list(map(str, lines))
246241
lines = filter(None, lines)
247242
irc.replies(lines, joiner=' ')
248243
else:

plugins/Web/plugin.py

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -30,29 +30,21 @@
3030
###
3131

3232
import re
33-
import sys
34-
import string
3533
import socket
3634

3735
import supybot.conf as conf
3836
import supybot.utils as utils
3937
from supybot.commands import *
40-
import supybot.utils.minisix as minisix
4138
import supybot.plugins as plugins
4239
import supybot.commands as commands
4340
import supybot.ircutils as ircutils
4441
import supybot.callbacks as callbacks
4542
from supybot.i18n import PluginInternationalization, internationalizeDocstring
4643
_ = PluginInternationalization('Web')
4744

48-
if minisix.PY3:
49-
from html.parser import HTMLParser
50-
from html.entities import entitydefs
51-
import http.client as http_client
52-
else:
53-
from HTMLParser import HTMLParser
54-
from htmlentitydefs import entitydefs
55-
import httplib as http_client
45+
from html.parser import HTMLParser
46+
from html.entities import entitydefs
47+
import http.client as http_client
5648

5749
class Title(utils.web.HtmlToText):
5850
entitydefs = entitydefs.copy()
@@ -227,15 +219,14 @@ def url_workaround(url):
227219
try:
228220
text = text.decode(encoding, 'replace')
229221
except UnicodeDecodeError:
230-
if minisix.PY3:
231-
if raiseErrors:
232-
irc.error(_('Could not guess the page\'s encoding. (Try '
233-
'installing python-charade.)'), Raise=True)
234-
else:
235-
self.log.info('Web plugin TitleSnarfer: URL <%s> Could '
236-
'not guess the page\'s encoding. (Try '
237-
'installing python-charade.)', url)
238-
return
222+
if raiseErrors:
223+
irc.error(_('Could not guess the page\'s encoding. (Try '
224+
'installing python-charade.)'), Raise=True)
225+
else:
226+
self.log.info('Web plugin TitleSnarfer: URL <%s> Could '
227+
'not guess the page\'s encoding. (Try '
228+
'installing python-charade.)', url)
229+
return
239230
try:
240231
parser = Title()
241232
parser.feed(text)

0 commit comments

Comments
 (0)