Skip to content

Commit f6729f6

Browse files
Add missing log message for generators discarded from active power control because targetP < minP (#1200)
Signed-off-by: PRABAKARAN Sylvestre <[email protected]>
1 parent 25df473 commit f6729f6

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfGenerator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,15 +361,17 @@ public void setParticipating(boolean participating) {
361361
public static boolean checkActivePowerControl(String generatorId, double targetP, double maxP,
362362
double minTargetP, double maxTargetP, double plausibleActivePowerLimit,
363363
boolean useActiveLimits, LfNetworkLoadingReport report) {
364-
boolean participating = true;
365364
if (Math.abs(targetP) < POWER_EPSILON_SI) {
365+
// if generator is not started, it is not participating, and we can skip the rest of the checks
366366
LOGGER.trace("Discard generator '{}' from active power control because targetP ({} MW) equals 0",
367367
generatorId, targetP);
368368
if (report != null) {
369369
report.generatorsDiscardedFromActivePowerControlBecauseTargetEqualsToZero++;
370370
}
371-
participating = false;
371+
return false;
372372
}
373+
374+
boolean participating = true;
373375
if (maxP > plausibleActivePowerLimit) {
374376
// note that we still want this check applied even if active power limits are not to be enforced,
375377
// e.g. in case of distribution modes proportional to maxP or remaining margin, we don't want to introduce crazy high participation

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,6 +1018,10 @@ private LfNetwork create(int numCC, int numSC, Network network, List<Bus> buses,
10181018
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of a targetP > maxP",
10191019
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseTargetPGreaterThanMaxP);
10201020
}
1021+
if (report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP > 0) {
1022+
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of a targetP < minP",
1023+
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseTargetPLowerThanMinP);
1024+
}
10211025
if (report.generatorsDiscardedFromActivePowerControlBecauseMaxPNotPlausible > 0) {
10221026
LOGGER.warn("Network {}: {} generators have been discarded from active power control because of maxP not plausible",
10231027
lfNetwork, report.generatorsDiscardedFromActivePowerControlBecauseMaxPNotPlausible);

0 commit comments

Comments
 (0)