update LoadFlowProviderAPI (#1299)

Signed-off-by: Didier Vidal <[email protected]>

Author: vidaldid-rte

src/main/java/com/powsybl/openloadflow/OpenLoadFlowProvider.java

@@ -305,7 +305,7 @@ public Optional<Extension<LoadFlowParameters>> loadSpecificParameters(Map<String
     }
 
     @Override
-    public List<Parameter> getSpecificParameters() {
+    public List<Parameter> getRawSpecificParameters() {
         return OpenLoadFlowParameters.SPECIFIC_PARAMETERS;
     }
 

src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java

@@ -391,7 +391,7 @@ void testCompareParameters() {
     @Test
     void testEqualsCloneAndUpdate() {
         OpenLoadFlowProvider provider = new OpenLoadFlowProvider();
-        provider.getSpecificParameters().forEach(sp -> {
+        provider.getRawSpecificParameters().forEach(sp -> {
             var p1 = new LoadFlowParameters();
             var p2 = new LoadFlowParameters();
             var pe1 = OpenLoadFlowParameters.create(p1);
@@ -459,7 +459,7 @@ void testEqualsCloneAndUpdate() {
     void testSerializationRoundTrip() {
         Set<String> nullableParams = Set.of("debugDir", "outerLoopNames");
         OpenLoadFlowProvider provider = new OpenLoadFlowProvider();
-        provider.getSpecificParameters().forEach(sp -> {
+        provider.getRawSpecificParameters().forEach(sp -> {
             LoadFlowParameters p1 = new LoadFlowParameters();
             OpenLoadFlowParameters e1 = OpenLoadFlowParameters.create(p1);
             List<String> vals;

src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java

@@ -87,7 +87,9 @@ void testGetExtendedVoltageInitializer() {
     @Test
     void specificParametersTest() {
         OpenLoadFlowProvider provider = new OpenLoadFlowProvider();
+
         assertEquals(80, provider.getSpecificParameters().size());
+
         LoadFlowParameters parameters = new LoadFlowParameters();
 
         provider.loadSpecificParameters(Collections.emptyMap())
@@ -114,7 +116,7 @@ void testCreateMapFromSpecificParameters() {
         long nullValueCOunt = parametersExt.toMap().values().stream().filter(Objects::isNull).count();
         assertEquals(80, map.size() + nullValueCOunt);
         assertEquals(2, nullValueCOunt); // debugDir and outerLoopNames are nullable
-        assertEquals(provider.getSpecificParameters().size(), map.size() + nullValueCOunt);
+        assertEquals(provider.getRawSpecificParameters().size(), map.size() + nullValueCOunt);
     }
 
     @Test

src/test/java/com/powsybl/openloadflow/ac/solver/AcSolverFactoryTest.java

@@ -107,7 +107,7 @@ public AcSolver create(LfNetwork network, AcLoadFlowParameters parameters, Equat
     @Test
     void testAcSolverTypeParam() {
         OpenLoadFlowProvider provider = new OpenLoadFlowProvider();
-        Parameter acSolverType = provider.getSpecificParameters().stream().filter(p -> p.getName().equals(OpenLoadFlowParameters.AC_SOLVER_TYPE_PARAM_NAME)).findFirst().orElseThrow();
+        Parameter acSolverType = provider.getRawSpecificParameters().stream().filter(p -> p.getName().equals(OpenLoadFlowParameters.AC_SOLVER_TYPE_PARAM_NAME)).findFirst().orElseThrow();
         assertEquals("NEWTON_RAPHSON", acSolverType.getDefaultValue());
         assertEquals(List.of("AC_SOLVER_MOCK", "FAST_DECOUPLED", "NEWTON_KRYLOV", "NEWTON_RAPHSON"), acSolverType.getPossibleValues());
     }

src/test/java/com/powsybl/openloadflow/sa/extensions/OpenSecurityAnalysisExtensionsTest.java

@@ -13,7 +13,7 @@
 import com.powsybl.commons.test.AbstractSerDeTest;
 import com.powsybl.contingency.BranchContingency;
 import com.powsybl.contingency.Contingency;
-import com.powsybl.contingency.contingency.list.DefaultContingencyList;
+import com.powsybl.contingency.list.DefaultContingencyList;
 import com.powsybl.contingency.json.ContingencyJsonModule;
 import com.powsybl.loadflow.LoadFlowParameters;
 import com.powsybl.openloadflow.OpenLoadFlowParameters;