-
Notifications
You must be signed in to change notification settings - Fork 49
Replace univocity parsers with FastCSV for CSV handling - PSSE #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
…n separate lines Signed-off-by: Nicolas Rol <[email protected]>
…st parsing utilities Signed-off-by: Nicolas Rol <[email protected]>
…ansformer impedances and windings, and update CSV processing logic accordingly Signed-off-by: Nicolas Rol <[email protected]>
…, update parsing utilities, and enhance CSV compatibility with new fields and corrections Signed-off-by: Nicolas Rol <[email protected]>
…V processing logic, and refine default field value handling Signed-off-by: Nicolas Rol <[email protected]>
…tests for improved parsing accuracy Signed-off-by: Nicolas Rol <[email protected]>
… logic and handle default values more consistently Signed-off-by: Nicolas Rol <[email protected]>
…andling, and fix inconsistent field mappings Signed-off-by: Nicolas Rol <[email protected]>
…c and remove unused cases Signed-off-by: Nicolas Rol <[email protected]>
… JSON and CSV processing, and fix rate field mappings Signed-off-by: Nicolas Rol <[email protected]>
…prove CSV handling, and enhance impedance correction processing Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
…ve CSV parsing logic, and enhance delimiter and quote management in `Context` Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
05e7a0d to
9f0ca76
Compare
Signed-off-by: Nicolas Rol <[email protected]>
|
I did some tests to compare the performances of this version vs main. Each test consisted of exporting a network and then importing the network from the generated file. Each operation was performed 50 times consecutively, and the results are based on the last 30 draws.
We can see here that the performances are way better when using FastCSV. Note: The exported files were checked and the only differences detected are due to an existing bug in the current PSS/E export |
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|



Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Change of dependency
What is the current behavior?
PowSyBl uses univocity-parsers for handling CSV files (parsing and writing), but this lib is abandoned since 2021.
What is the new behavior (if this is a feature change)?
PowSyBl now uses FastCSV for handling CSV files.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: