ReservedSql appears to have methods it does not have

[rytido]

const sqli = await sql.reserve();
await sqli.begin(async (sql) => await sql`select 1`);
sqli.release();
// sqli.begin is not a function

Is there a technical reason transactions are not supported by reserved connections?

[porsager]

I suppose this is typescript related?

If you reserve a connection you are expected to handle transactions yourself by calling sqlbegin ... etc, so it is correct that there is no sql.begin function on a reserved instance.

Feel free to make a PR for the typescript if that's what your issue is about.

[rytido]

Gotcha, yeah, just the typescript. I'll try to get around to a PR. Love this library, thank you.

[Ericnr]

I suppose this is typescript related?

If you reserve a connection you are expected to handle transactions yourself by calling sqlbegin ... etc, so it is correct that there is no sql.begin function on a reserved instance.

Feel free to make a PR for the typescript if that's what your issue is about.

is there a good reason why a reserved connection couldn't have the .begin method, along with all other methods sql has?

[vitallygolovanov]

is there a good reason why a reserved connection couldn't have the .begin method, along with all other methods sql has?

Second that. In my code most every function that uses postgres.js accepts a transaction/connection object as an optional argument that defaults to a global sql instance, so it can be used both in a transaction and outside of one.

someQueryMethod(tql: Sql<any> = sql) {
   //... do stuff
   const result = await tql`SELECT * FROM whatever`;
   
   // or
   const transactionResult = await tql.begin((ttql)=> {
      // ... do transaction stuff
   } 
}

And the fact that calling .begin() on a reserved connection breaks this neat logic is upsetting and right now I'm looking at workaround options.

Then again, it may be that I'm once again overcomplicating things.