Simplify backend URL parsing by requiring proxy_to to include the scheme and update example configurations accordingly.

Author: jorgecuesta

README.md

@@ -45,7 +45,7 @@ Response: Returns backend response to client
 
 ```csv
 subdomain,proxy_to,strip_path,strip_query
-eth,backend.example.com/api,false,false
+eth,https://backend.example.com/api,false,false
 ```
 
 ### Fields
@@ -57,12 +57,12 @@ eth,backend.example.com/api,false,false
 
 ### Examples
 
-| Configuration                                | Incoming Request                                | Proxied Request                                |
-|----------------------------------------------|-------------------------------------------------|------------------------------------------------|
-| `eth,backend.example.com/v1/abc,true,true`   | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc`           |
-| `eth,backend.example.com/v1/abc,false,true`  | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc/foo`       |
-| `eth,backend.example.com/v1/abc,false,false` | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc/foo?bar=1` |
-| `eth,backend.example.com/v1/abc,true,false`  | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc?bar=1`     |
+| Configuration                                        | Incoming Request                                | Proxied Request                                |
+|------------------------------------------------------|-------------------------------------------------|------------------------------------------------|
+| `eth,https://backend.example.com/v1/abc,true,true`   | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc`           |
+| `eth,https://backend.example.com/v1/abc,false,true`  | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc/foo`       |
+| `eth,https://backend.example.com/v1/abc,false,false` | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc/foo?bar=1` |
+| `eth,https://backend.example.com/v1/abc,true,false`  | `https://eth.test-api.pocket.network/foo?bar=1` | `https://backend.example.com/v1/abc?bar=1`     |
 
 ### Header Forwarding
 

examples/proxies.csv

@@ -1,4 +1,4 @@
 subdomain,proxy_to,strip_path,strip_query
-httpbin_strip,localhost:4040/get,true,true
-httpbin_path,localhost:4040/anything,false,true
-httpbin,localhost:4040,false,false
+httpbin_strip,http://localhost:4040/get,true,true
+httpbin_path,http://localhost:4040/anything,false,true
+httpbin,http://localhost:4040,false,false

main.go

@@ -277,12 +277,8 @@ func (s *ProxyService) HandleProxy(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	// Parse backend URL
-	scheme := "https"
-	if r.TLS == nil {
-		scheme = "http"
-	}
-	targetURL, err := url.Parse(fmt.Sprintf("%s://%s", scheme, rule.ProxyTo))
+	// Parse backend URL (proxy_to must include scheme: http:// or https://)
+	targetURL, err := url.Parse(rule.ProxyTo)
 	if err != nil {
 		log.Printf("ERROR: Invalid proxy_to URL for subdomain '%s': %v", subdomain, err)
 		proxyRequestsTotal.WithLabelValues(subdomain, "500").Inc()
@@ -302,7 +298,7 @@ func (s *ProxyService) HandleProxy(w http.ResponseWriter, r *http.Request) {
 		startTime:     start,
 		rule:          rule,
 		targetURL:     targetURL,
-		scheme:        scheme,
+		scheme:        targetURL.Scheme,
 		host:          host,
 		clientIP:      clientIP,
 		originalPath:  r.URL.Path,
@@ -311,7 +307,7 @@ func (s *ProxyService) HandleProxy(w http.ResponseWriter, r *http.Request) {
 	r = r.WithContext(ctx)
 
 	// Get or create a cached proxy for this backend
-	cacheKey := fmt.Sprintf("%s://%s", scheme, rule.ProxyTo)
+	cacheKey := targetURL.Scheme + "://" + targetURL.Host
 	var proxy *httputil.ReverseProxy
 
 	if cached, ok := s.proxies.Load(cacheKey); ok {