Skip to content

Conversation

@Olshansk
Copy link
Collaborator

@Olshansk Olshansk commented Jul 13, 2023

Description

Summary generated by Reviewpad on 14 Jul 23 23:17 UTC

This pull request includes a series of patches that make changes to the file debug.go in the shared/k8s directory.

Patch 1/5: The patch retrieves keys for all actors from k8s secrets. It adds support for retrieving private keys for validators, servicers, fisherman, and applications.

Patch 2/5: This patch fixes a linter error in the fetchPrivateKeys function by updating the function signature to use a single string parameter for resourceName and actor.

Patch 3/5: This patch further fixes linter errors in the same function and shortens the code by removing unnecessary switch cases.

Patch 4/5: This patch updates the constant for the secret resource name from privateKeysSecretResourceNameFisherman to privateKeysSecretResourceNameFishermen.

Patch 5/5: This patch fixes a typo in the function name FetchFishermanPrivateKeys by updating the privateKeysSecretResourceName to privateKeysSecretResourceNameFishermen.

Please review these changes and ensure they are appropriate.

Issue

Added as a TODO in #869:

Screenshot 2023-07-12 at 5 10 03 PM

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Fetch keys for all actors from k8s instead of just validators so they can be used in our debug libraries

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@Olshansk Olshansk added tooling tooling to support development, testing et al testing Defining, adding, automating or modifying tests labels Jul 13, 2023
@Olshansk Olshansk requested review from adshmh, dylanlott and okdas July 13, 2023 00:12
@Olshansk Olshansk self-assigned this Jul 13, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 13, 2023
@Olshansk Olshansk added the e2e-devnet-test Runs E2E tests on devnet label Jul 13, 2023
Copy link
Contributor

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to make fisherman plural.

Copy link
Contributor

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olshansk Olshansk merged commit b55b6f9 into main Jul 14, 2023
@Olshansk Olshansk deleted the actor_secrets branch July 14, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-devnet-test Runs E2E tests on devnet small Pull request is small testing Defining, adding, automating or modifying tests tooling tooling to support development, testing et al waiting-for-review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants