Commit 54740c8
committed
kind jobs: stop relying on implicit SKIP=[Serial]
All jobs using e2e-k8s.sh with PARALLEL=true automatically skipped serial tests
even though technically they now could run in the job:
https://github.com/kubernetes-sigs/kind/blame/d1eecc46e30cac9d35cd32dc52677ef75ec22e18/hack/ci/e2e-k8s.sh#L226-L234
kubernetes-sigs/kind#4015 is changing that mandatory
skip for jobs using LABEL_FILTER because it may be desirable to include serial
tests, depending on the job. It's also better to be explicit about it in each
job's LABEL_FILTER to avoid confusion and potential mistakes (not running tests
that were expected to run).
To prepare for that change, jobs get updated based on the following principles:
- If a presubmit runs infrequently and is only invoked to test certain aspects,
then including serial tests is desirable to get full test coverage of that
aspect. Example: pull-kubernetes-e2e-kind-beta-features
- If a presubmit runs always, serial tests should be excluded.
Example: pull-kubernetes-e2e-kind
- Periodic jobs should always run all supported tests, including the serial
ones. Example: ci-kubernetes-e2e-kind
- Canary jobs match the behavior of the non-canary variant.
Example: pull-kubernetes-e2e-kind-canary
To make it more obvious where the upcoming e2e-k8s.sh will change test selection,
"Includes serial tests for the sake of completeness." comments get added.
Those are not true *right now*, but will be once the script is changed.1 parent 5403aee commit 54740c8
File tree
6 files changed
+24
-28
lines changed- config/jobs
- kubernetes-sigs
- kind
- kube-network-policies
- kubernetes
- sig-arch
- sig-network
- sig-release/release-branch-jobs
- sig-testing
6 files changed
+24
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
| 239 | + | |
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| |||
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
281 | | - | |
| 281 | + | |
282 | 282 | | |
283 | 283 | | |
284 | 284 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| 123 | + | |
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
948 | 948 | | |
949 | 949 | | |
950 | 950 | | |
951 | | - | |
| 951 | + | |
952 | 952 | | |
953 | 953 | | |
954 | 954 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1029 | 1029 | | |
1030 | 1030 | | |
1031 | 1031 | | |
1032 | | - | |
| 1032 | + | |
1033 | 1033 | | |
1034 | 1034 | | |
1035 | 1035 | | |
| |||
1076 | 1076 | | |
1077 | 1077 | | |
1078 | 1078 | | |
1079 | | - | |
| 1079 | + | |
1080 | 1080 | | |
1081 | 1081 | | |
1082 | 1082 | | |
| |||
1202 | 1202 | | |
1203 | 1203 | | |
1204 | 1204 | | |
| 1205 | + | |
1205 | 1206 | | |
1206 | 1207 | | |
1207 | 1208 | | |
| |||
1280 | 1281 | | |
1281 | 1282 | | |
1282 | 1283 | | |
| 1284 | + | |
1283 | 1285 | | |
1284 | 1286 | | |
1285 | 1287 | | |
| |||
Lines changed: 12 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
| 303 | + | |
303 | 304 | | |
304 | 305 | | |
305 | 306 | | |
| |||
345 | 346 | | |
346 | 347 | | |
347 | 348 | | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | 349 | | |
| 350 | + | |
353 | 351 | | |
354 | 352 | | |
355 | 353 | | |
| |||
395 | 393 | | |
396 | 394 | | |
397 | 395 | | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | 396 | | |
| 397 | + | |
403 | 398 | | |
404 | 399 | | |
405 | 400 | | |
| |||
447 | 442 | | |
448 | 443 | | |
449 | 444 | | |
| 445 | + | |
450 | 446 | | |
451 | 447 | | |
452 | 448 | | |
| |||
493 | 489 | | |
494 | 490 | | |
495 | 491 | | |
496 | | - | |
497 | | - | |
498 | | - | |
499 | | - | |
500 | 492 | | |
| 493 | + | |
501 | 494 | | |
502 | 495 | | |
503 | 496 | | |
| |||
544 | 537 | | |
545 | 538 | | |
546 | 539 | | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | 540 | | |
| 541 | + | |
552 | 542 | | |
553 | 543 | | |
554 | 544 | | |
| |||
595 | 585 | | |
596 | 586 | | |
597 | 587 | | |
| 588 | + | |
598 | 589 | | |
599 | 590 | | |
600 | 591 | | |
| |||
653 | 644 | | |
654 | 645 | | |
655 | 646 | | |
| 647 | + | |
656 | 648 | | |
657 | 649 | | |
658 | 650 | | |
| |||
0 commit comments