Skip to content

Commit cc9cfeb

Browse files
committed
change: log validation errors
1 parent a1cdcae commit cc9cfeb

File tree

1 file changed

+20
-7
lines changed
  • server/lib/publisher_web/controllers

1 file changed

+20
-7
lines changed

server/lib/publisher_web/controllers/api.ex

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ defmodule PublisherWeb.Controllers.API do
2727
def podcast_feed_url(conn, headers) do
2828
with_validation(conn, headers_to_map(headers), Validator.WordPressSiteHeader, fn conn, data ->
2929
case Podcast.feed_url(data."wordpress-site") do
30-
{:ok, data} -> json(conn, data)
30+
{:ok, data} ->
31+
json(conn, data)
32+
3133
{:error, reason} ->
3234
Logger.error("podcast_feed_url doesnot work reason: #{inspect(reason)}")
3335
bad_request_resp(conn, "Error: Podcast.feed_url")
@@ -38,7 +40,9 @@ defmodule PublisherWeb.Controllers.API do
3840
def set_podcast_settings(conn, headers, body) do
3941
with_validation(conn, headers_to_map(headers), Validator.WordPressAuthHeaders, fn conn, _ ->
4042
case Podcast.set_settings(headers, body) do
41-
:ok -> json(conn, %{})
43+
:ok ->
44+
json(conn, %{})
45+
4246
{:error, reason} ->
4347
Logger.error("podcast_set_settings reason: #{inspect(reason)}")
4448
bad_request_resp(conn, "Error: Podcast.set_settings")
@@ -50,7 +54,9 @@ defmodule PublisherWeb.Controllers.API do
5054
with_validation(conn, headers_to_map(headers), Validator.WordPressAuthHeaders, fn conn, _ ->
5155
with_validation(conn, body, Validator.SavePodcast, fn conn, body_data ->
5256
case Podcast.save_podcast_data(headers, body_data) do
53-
{:ok, data} -> json(conn, data)
57+
{:ok, data} ->
58+
json(conn, data)
59+
5460
{:error, reason} ->
5561
Logger.error("podcast_save_data reason: #{inspect(reason)}")
5662
bad_request_resp(conn, "Error: Podcast.save_podcast_data")
@@ -63,7 +69,9 @@ defmodule PublisherWeb.Controllers.API do
6369
with_validation(conn, headers_to_map(headers), Validator.WordPressAuthHeaders, fn conn, _ ->
6470
with_validation(conn, body, Validator.SavePodcastImage, fn conn, body_data ->
6571
case Podcast.save_podcast_image(headers, body_data) do
66-
{:ok, info} -> json(conn, info)
72+
{:ok, info} ->
73+
json(conn, info)
74+
6775
{:error, reason} ->
6876
Logger.error("podcast_save_image reason: #{inspect(reason)}")
6977
bad_request_resp(conn, "Error: Podcast.save_podcast_image")
@@ -76,7 +84,9 @@ defmodule PublisherWeb.Controllers.API do
7684
with_validation(conn, headers_to_map(headers), Validator.WordPressAuthHeaders, fn conn, _ ->
7785
with_validation(conn, body, Validator.CopyPodcastImage, fn conn, body_data ->
7886
case Podcast.copy_podcast_image(headers, body_data) do
79-
{:ok, info} -> json(conn, info)
87+
{:ok, info} ->
88+
json(conn, info)
89+
8090
{:error, reason} ->
8191
Logger.error("podcast_copy_image reason: #{inspect(reason)}")
8292
bad_request_resp(conn, "Error: Podcast.copy_podcast_image")
@@ -90,7 +100,7 @@ defmodule PublisherWeb.Controllers.API do
90100
with_validation(conn, body, Validator.SaveEpisode, fn conn, _ ->
91101
with_validation(conn, body["media_file"], Validator.SaveEnclosure, fn conn, _ ->
92102
with_validation_array(conn, body["chapters"], Validator.SaveChapters, fn conn, _ ->
93-
case Episode.save(conn, body) do
103+
case Episode.save(conn, body) do
94104
:ok -> json(conn, %{status: "success"})
95105
_ -> bad_request_resp(conn, "Error: unable to save episode")
96106
end
@@ -106,9 +116,12 @@ defmodule PublisherWeb.Controllers.API do
106116
success_fn.(conn, data)
107117

108118
{:error, changeset} ->
119+
errors = validator_mod.changeset_to_errors(changeset)
120+
Logger.warning("Validation Error: #{inspect(errors)}")
121+
109122
conn
110123
|> put_status(:bad_request)
111-
|> json(%{errors: validator_mod.changeset_to_errors(changeset)})
124+
|> json(%{errors: errors})
112125
end
113126
end
114127

0 commit comments

Comments
 (0)