useShallow - may be docs has broken example

[akhilshastri]

i m using react v19.1.0 with zustand 5.0.4, - doc link https://zustand.docs.pmnd.rs/guides/prevent-rerenders-with-use-shallow#example

it throws error in browser console -

codesandbox : https://codesandbox.io/p/devbox/stupefied-drake-hszyck

[dai-shi]

That's correct, because it shows the problematic code.

---

This change causes BearNames rerenders even though the actual output of names has not changed

Maybe, it should clearly say it may cause infinite loop. What do you think? @dbritto-dev

[dbritto-dev]

@akhilshastri @dai-shi shall add a ref to useSyncExternalStore react docs?

[dai-shi]

That sounds unrelated to this case.

[dbritto-dev]

@dai-shi the error is coming from useSyncExternalStore -> getSnapshot

[dbritto-dev]

shall we make clear when and why we get that error/warning?

[dai-shi]

I see. Well, it's up to you.
The original concern reported, as I understand, is it doesn't clearly stated that it may cause infinite loop. So, explaining with uSES doesn't seem to help a lot.

[akhilshastri]

i think, we only need to update the docs and provide the details of expected result of code, with current context its not clear.

[dbritto-dev]

Well in any case I'd like to deprecate that guide in favor of new api docs