PEP 420 native namespace #39
Conversation
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
gforcada
force-pushed
the
pep-420-native-namespace
branch
from
38b6b66 to
afd068f
Compare
Pull Request Test Coverage Report for Build 19616695035Details
💛 - Coveralls |
gforcada
force-pushed
the
pep-420-native-namespace
branch
from
afd068f to
86dd0a9
Compare
|
@mauritsvanrees do we need the full 3.10-3.13 matrix for unit and integration, or could we save some CI cycles like we do on Other than that, the conversion from zope.meta to plone.meta seems to be fine eyeballing the diff |
|
3.10 and 3.13 should be fine. |
The paths need to be on one line. Otherwise you get test outcome like this: ``` py313-integration: commands[1]> -test-path=test-packages/example.different/src py313-integration: Exception running subprocess [Errno 2] No such file or directory: '-test-path=test-packages/example.different/src' py313-integration: exit 2 (0.00 seconds) /Users/maurits/community/plone-coredev/6.2/src/plone.autoinclude> -test-path=test-packages/example.different/src py313-integration: command failed but is marked ignore outcome so handling it as success ```
We had 'tests' and 'Tests'.
Actually, let's test them all. The tests don't take long. And they are the kind of tests where I fear there could be corner cases. On the other hand: it would be more useful to test on a range of setuptools versions, like we do in I did fix a problem in the integration tests, where the paths were wrong because the backslash at the end was removed. And somehow tox thought these errors could be ignored. |
Part of plone/Products.CMFPlone#3928
Seems that this package was using
zope.metarather thanplone.meta, should we keep it this way, or move it toplone.metaas this PR is partially doing, probably it needs some adjustments, but as I'm doing the PRs for all native namespaces, I prefer to leave it half done here, and then I revisit it 😅