TinyMCE: Restore ability to choose which content are folderish types #4212
Conversation
|
@frapell thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
|
||
| configuration = { | ||
| "base_url": self.context.absolute_url(), | ||
| "imageTypes": image_types, |
There was a problem hiding this comment.
instead of directly setting the contentbrowser options, we should add folder_types in the base configuration with "folderTypes": folder_types ... tinymce pattern later decides if "folderTypes" should become "browseableTypes" in the imageModal ...
There was a problem hiding this comment.
see already existing option: https://github.com/plone/mockup/blob/master/src/pat/tinymce/tinymce.js#L87
|
Note: there is a |
refs gh-4207