Commit ebf324c
authored
Remove cx-Oracle import test (#271)
`//test:cx_oracle_darwin_build_test` just ensures that cx-Oracle is
importable and defines a `__version__` attribute. The test name implies
that the build process for cx-Oracle itself - specifically on Darwin - is
what matters in this test, although it's not clear why: the test
predates Please's plugin architecture, and was inherited from the main
Please repo.
cx-Oracle has been abandoned since 2022 [1] and hasn't had a new version
published on PyPI since 2021 [2]. The final version only has pre-built
wheels available for Python <= 3.10 manylinux SOABIs, so pip has to
build it from source for the vast majority of SOABIs. It's not clear why
this is a price worth paying any more, so remove it (and the test that
depends on it).
[1] https://oracle.github.io/python-cx_Oracle/
[2] https://pypi.org/project/cx-Oracle/8.3.0/1 parent 2ded40d commit ebf324c
File tree
3 files changed
+0
-27
lines changed- test
- third_party/python
3 files changed
+0
-27
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | 140 | | |
150 | 141 | | |
151 | 142 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | 386 | | |
394 | 387 | | |
395 | 388 | | |
| |||
0 commit comments