Skip to content

Commit ebf324c

Browse files
Remove cx-Oracle import test (#271)
`//test:cx_oracle_darwin_build_test` just ensures that cx-Oracle is importable and defines a `__version__` attribute. The test name implies that the build process for cx-Oracle itself - specifically on Darwin - is what matters in this test, although it's not clear why: the test predates Please's plugin architecture, and was inherited from the main Please repo. cx-Oracle has been abandoned since 2022 [1] and hasn't had a new version published on PyPI since 2021 [2]. The final version only has pre-built wheels available for Python <= 3.10 manylinux SOABIs, so pip has to build it from source for the vast majority of SOABIs. It's not clear why this is a price worth paying any more, so remove it (and the test that depends on it). [1] https://oracle.github.io/python-cx_Oracle/ [2] https://pypi.org/project/cx-Oracle/8.3.0/
1 parent 2ded40d commit ebf324c

File tree

3 files changed

+0
-27
lines changed

3 files changed

+0
-27
lines changed

test/BUILD

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,6 @@ python_test(
137137
data = {"txt": ["data.txt"]},
138138
)
139139

140-
python_test(
141-
name = "cx_oracle_darwin_build_test",
142-
srcs = ["cx_oracle_darwin_build_test.py"],
143-
labels = [
144-
"pip",
145-
],
146-
deps = ["//third_party/python:cx_oracle"],
147-
)
148-
149140
plugin_e2e_test(
150141
name = "pip_libary_zip_safe_label_test",
151142
repo = "zip_safe_label_repo",

test/cx_oracle_darwin_build_test.py

Lines changed: 0 additions & 11 deletions
This file was deleted.

third_party/python/BUILD

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,13 +383,6 @@ pip_library(
383383
version = "1.5",
384384
)
385385

386-
pip_library(
387-
name = "cx_oracle",
388-
package_name = "cx-Oracle",
389-
licences = ["BSD-3-Clause"],
390-
version = "8.2.1",
391-
)
392-
393386
pip_library(
394387
name = "distlib",
395388
licences = ["PSF-2.0"],

0 commit comments

Comments
 (0)