Skip to content

Commit 8966d5a

Browse files
Merge pull request #32 from player-ui/fix/upgrade-devtools-client-0.16.1-next.3
Upgrade to @player-devtools 0.16.1-next.3, fix minified react crash
2 parents 3b0e511 + f8a6c00 commit 8966d5a

3 files changed

Lines changed: 2170 additions & 1903 deletions

File tree

‎package.json‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@
2121
"@auto-it/git-tag": "^11.1.6",
2222
"@auto-it/version-file": "^11.1.6",
2323
"@plasmohq/storage": "^1.10.0",
24-
"@player-tools/devtools-client": "0.9.0-next.0",
25-
"@player-tools/devtools-types": "0.9.0-next.0",
26-
"@player-ui/pubsub-plugin": "0.7.2-next.4",
27-
"@player-ui/react": "0.7.2-next.4",
24+
"@player-devtools/client-react": "0.16.1-next.3",
25+
"@player-devtools/types": "0.16.1-next.3",
26+
"@player-ui/player": ">=0.15.4",
27+
"@player-ui/pubsub-plugin": ">=0.15.4",
28+
"@player-ui/react": ">=0.15.4",
2829
"dequal": "^2.0.3",
2930
"dset": "^3.1.3",
3031
"immer": "^10.0.3",

‎panels/devtools/index.tsx‎

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
1-
import { Panel } from "@player-tools/devtools-client"
2-
import type { CommunicationLayerMethods } from "@player-tools/devtools-types"
3-
import React from "react"
4-
import ReactDOM from "react-dom"
1+
import { Panel } from "@player-devtools/client-react"
2+
import type {
3+
ExtensionSupportedEvents,
4+
MessengerOptions
5+
} from "@player-devtools/types"
6+
import React, { Suspense } from "react"
7+
import { createRoot } from "react-dom/client"
58
import browser from "webextension-polyfill"
69

710
const port = browser.runtime.connect()
811

9-
const communicationLayer: CommunicationLayerMethods = {
12+
const communicationLayer: Pick<
13+
MessengerOptions<ExtensionSupportedEvents>,
14+
"sendMessage" | "addListener" | "removeListener"
15+
> = {
1016
sendMessage: async (message) =>
1117
port.postMessage({
1218
tabId: browser.devtools.inspectedWindow.tabId,
@@ -20,7 +26,8 @@ const communicationLayer: CommunicationLayerMethods = {
2026
}
2127
}
2228

23-
ReactDOM.render(
24-
<Panel communicationLayer={communicationLayer} />,
25-
document.getElementById("root")
29+
createRoot(document.getElementById("root")!).render(
30+
<Suspense fallback={null}>
31+
<Panel communicationLayer={communicationLayer} />
32+
</Suspense>
2633
)

0 commit comments

Comments
 (0)