Add ESP32 support; fix bug #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very similar to ESP8266.
Things were behaving strangely and I was getting tons of DISCARDING DATA messages; I think it's because opcRead() should return when it needs to wait for stuff instead of calling the opcMsgReceivedCallback_ regardless.
hobzcalvin
added a commit
to hobzcalvin/blume
that referenced
this pull request
Nov 28, 2017
Lots of precompiler stuff, hacks, special cases, etc. BLE stuff on ESP32 relies on my fork of the BLE ESP32 stuff; pull request is out: nkolban/ESP32_BLE_Arduino#9 OPC doesn't work very well without my fix: plasticrake/OpcServer#5
Clients can call mDNSBegin() to start broadcasting the service "_openpixelctrl", which has been approved by OPC creator Ping as a suitable mDNS service name. Only ESP32 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the library! I'm using it on an ESP32.