Skip to content

Commit c9090da

Browse files
committed
pkp/pkp-lib#13059 updated column and event description
1 parent edb11c7 commit c9090da

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

classes/services/PublicationFormatService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public function deleteFormat($publicationFormat, $submission, $context)
7575
'assocId' => $submission->getId(),
7676
'eventType' => SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_REMOVE,
7777
'userId' => Validation::loggedInAs() ?? Application::get()->getRequest()->getUser()?->getId(),
78-
'impersonatedAsUserId' => Validation::loggedInAs() ? Application::get()->getRequest()->getUser()?->getId() : null,
78+
'impersonatedUserId' => Validation::loggedInAs() ? Application::get()->getRequest()->getUser()?->getId() : null,
7979
'message' => 'submission.event.publicationFormatRemoved',
8080
'isTranslated' => false,
8181
'dateLogged' => Core::getCurrentDate(),

controllers/grid/catalogEntry/PublicationFormatGridHandler.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ public function setApproved($args, $request)
402402
'assocId' => $this->getSubmission()->getId(),
403403
'eventType' => $newApprovedState ? SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_PUBLISH : SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_UNPUBLISH,
404404
'userId' => Validation::loggedInAs() ?? $request->getUser()?->getId(),
405-
'impersonatedAsUserId' => Validation::loggedInAs() ? $request->getUser()?->getId() : null,
405+
'impersonatedUserId' => Validation::loggedInAs() ? $request->getUser()?->getId() : null,
406406
'message' => $newApprovedState ? 'submission.event.publicationFormatPublished' : 'submission.event.publicationFormatUnpublished',
407407
'isTranslated' => false,
408408
'dateLogged' => Core::getCurrentDate(),
@@ -452,7 +452,7 @@ public function setAvailable($args, $request)
452452
'assocId' => $this->getSubmission()->getId(),
453453
'eventType' => $newAvailableState ? SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_AVAILABLE : SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_UNAVAILABLE,
454454
'userId' => Validation::loggedInAs() ?? $request->getUser()?->getId(),
455-
'impersonatedAsUserId' => Validation::loggedInAs() ? $request->getUser()?->getId() : null,
455+
'impersonatedUserId' => Validation::loggedInAs() ? $request->getUser()?->getId() : null,
456456
'message' => $newAvailableState ? 'submission.event.publicationFormatMadeAvailable' : 'submission.event.publicationFormatMadeUnavailable',
457457
'isTranslated' => false,
458458
'dateLogged' => Core::getCurrentDate(),
@@ -614,7 +614,7 @@ public function setProofFileCompletion($args, $request)
614614
'assocId' => $submissionFile->getId(),
615615
'eventType' => SubmissionFileEventLogEntry::SUBMISSION_LOG_FILE_SIGNOFF_SIGNOFF,
616616
'userId' => Validation::loggedInAs() ?? $user?->getId(),
617-
'impersonatedAsUserId' => Validation::loggedInAs() ? $user?->getId() : null,
617+
'impersonatedUserId' => Validation::loggedInAs() ? $user?->getId() : null,
618618
'message' => 'submission.event.signoffSignoff',
619619
'isTranslated' => false,
620620
'dateLogged' => Core::getCurrentDate(),

controllers/grid/catalogEntry/form/PublicationFormatForm.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ public function execute(...$functionParams)
277277
'assocId' => $this->getMonograph()->getId(),
278278
'eventType' => SubmissionEventLogEntry::SUBMISSION_LOG_PUBLICATION_FORMAT_CREATE,
279279
'userId' => Validation::loggedInAs() ?? Application::get()->getRequest()->getUser()?->getId(),
280-
'impersonatedAsUserId' => Validation::loggedInAs() ? Application::get()->getRequest()->getUser()?->getId() : null,
280+
'impersonatedUserId' => Validation::loggedInAs() ? Application::get()->getRequest()->getUser()?->getId() : null,
281281
'message' => 'submission.event.publicationFormatCreated',
282282
'isTranslate' => false,
283283
'dateLogged' => Core::getCurrentDate(),

locale/en/locale.po

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,11 +1172,13 @@ msgstr ""
11721172
msgid "log.review.reviewDueDateSet"
11731173
msgstr "The due date for the round {$round} review of submission {$submissionId} by {$reviewerName} has been set to {$dueDate}."
11741174

1175+
#, fuzzy
11751176
msgid "log.review.reviewDeclined"
1176-
msgstr "{$reviewerName} has declined the round {$round} review for submission {$submissionId}."
1177+
msgstr "The round {$round} review assigned to {$reviewerName} for submission {$submissionId} has been declined."
11771178

1179+
#, fuzzy
11781180
msgid "log.review.reviewAccepted"
1179-
msgstr "{$reviewerName} has accepted the round {$round} review for submission {$submissionId}."
1181+
msgstr "The round {$round} review assigned to {$reviewerName} for submission {$submissionId} has been accepted."
11801182

11811183
msgid "log.review.reviewUnconsidered"
11821184
msgstr "{$editorName} has marked the round {$round} review for submission {$submissionId} as unconsidered."

0 commit comments

Comments
 (0)