From 8955abecfa8d62c4d129e5a5a9d56b40f83e0104 Mon Sep 17 00:00:00 2001 From: glorv Date: Thu, 5 Sep 2024 10:58:07 +0800 Subject: [PATCH 1/3] add new dynamic configure for flow-control --- dynamic-config.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dynamic-config.md b/dynamic-config.md index 1b5d8a0e53cab..7228c30606f1e 100644 --- a/dynamic-config.md +++ b/dynamic-config.md @@ -225,6 +225,11 @@ The following TiKV configuration items can be modified dynamically: | `server.raft-msg-max-batch-size` | Sets the maximum number of Raft messages that are contained in a single gRPC message | | `server.simplify-metrics` | Controls whether to simplify the sampling monitoring metrics | | `storage.block-cache.capacity` | The size of shared block cache (supported since v4.0.3) | +| storage.flow-control.enable | Determines whether to enable the flow control mechanism. | +| storage.flow-control.memtables-threshold | The threshold of kvDB memtable numbers that triggers flow control. | +| storage.flow-control.l0-files-threshold | The threshold of kvDB L0 file numbers that triggers flow control. | +| storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control. | +| storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests and reports the `ServerIsBusy` error. | | `storage.scheduler-worker-pool-size` | The number of threads in the Scheduler thread pool | | `backup.num-threads` | The number of backup threads (supported since v4.0.3) | | `split.qps-threshold` | The threshold to execute `load-base-split` on a Region. If the QPS of read requests for a Region exceeds `qps-threshold` for 10 consecutive seconds, this Region should be split.| From c9b8e30c1cfdcbaedc2c49798c31a60cc9c2a84d Mon Sep 17 00:00:00 2001 From: Aolin Date: Tue, 10 Sep 2024 11:30:45 +0800 Subject: [PATCH 2/3] Apply suggestions from code review --- dynamic-config.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dynamic-config.md b/dynamic-config.md index 7228c30606f1e..823d2050ccb7a 100644 --- a/dynamic-config.md +++ b/dynamic-config.md @@ -225,11 +225,11 @@ The following TiKV configuration items can be modified dynamically: | `server.raft-msg-max-batch-size` | Sets the maximum number of Raft messages that are contained in a single gRPC message | | `server.simplify-metrics` | Controls whether to simplify the sampling monitoring metrics | | `storage.block-cache.capacity` | The size of shared block cache (supported since v4.0.3) | -| storage.flow-control.enable | Determines whether to enable the flow control mechanism. | -| storage.flow-control.memtables-threshold | The threshold of kvDB memtable numbers that triggers flow control. | -| storage.flow-control.l0-files-threshold | The threshold of kvDB L0 file numbers that triggers flow control. | -| storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control. | -| storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests and reports the `ServerIsBusy` error. | +| storage.flow-control.enable | Determines whether to enable the flow control mechanism | +| storage.flow-control.memtables-threshold | The threshold of kvDB memtable numbers that triggers flow control | +| storage.flow-control.l0-files-threshold | The threshold of kvDB L0 file numbers that triggers flow control | +| storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control | +| storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests and report the `ServerIsBusy` error | | `storage.scheduler-worker-pool-size` | The number of threads in the Scheduler thread pool | | `backup.num-threads` | The number of backup threads (supported since v4.0.3) | | `split.qps-threshold` | The threshold to execute `load-base-split` on a Region. If the QPS of read requests for a Region exceeds `qps-threshold` for 10 consecutive seconds, this Region should be split.| From 43fdce748984894f0770de46b7de6e5b29dae42c Mon Sep 17 00:00:00 2001 From: glorv Date: Fri, 27 Sep 2024 16:56:27 +0800 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Grace Cai --- dynamic-config.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dynamic-config.md b/dynamic-config.md index 823d2050ccb7a..f9f83caca9a26 100644 --- a/dynamic-config.md +++ b/dynamic-config.md @@ -226,10 +226,10 @@ The following TiKV configuration items can be modified dynamically: | `server.simplify-metrics` | Controls whether to simplify the sampling monitoring metrics | | `storage.block-cache.capacity` | The size of shared block cache (supported since v4.0.3) | | storage.flow-control.enable | Determines whether to enable the flow control mechanism | -| storage.flow-control.memtables-threshold | The threshold of kvDB memtable numbers that triggers flow control | -| storage.flow-control.l0-files-threshold | The threshold of kvDB L0 file numbers that triggers flow control | -| storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control | -| storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests and report the `ServerIsBusy` error | +| storage.flow-control.memtables-threshold | The maximum number of kvDB memtables that trigger flow control | +| storage.flow-control.l0-files-threshold | The maximum number of kvDB L0 files that trigger flow control | +| storage.flow-control.soft-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject some write requests | +| storage.flow-control.hard-pending-compaction-bytes-limit | The threshold of kvDB pending compaction bytes that triggers flow control mechanism to reject all write requests | | `storage.scheduler-worker-pool-size` | The number of threads in the Scheduler thread pool | | `backup.num-threads` | The number of backup threads (supported since v4.0.3) | | `split.qps-threshold` | The threshold to execute `load-base-split` on a Region. If the QPS of read requests for a Region exceeds `qps-threshold` for 10 consecutive seconds, this Region should be split.|