kv488: assert that marks are consistent over parts

Summary:
We can add this script only now, because the first movement has been
completed. Similarly, we will only be able to add checking for each
later movement once it has also been completed.

Test Plan:
Running `./assert_consistent_marks.sh` or `make quickcheck` passes as
is, but if a `\barNumberCheck #1` is changed to `\barNumberCheck #2`,
then these invocations fail with one “missing” message and one
“superfluous” message, as desired.

Author: wchargin

ftp/MozartWA/KV488/Makefile

@@ -26,6 +26,7 @@ midi: \
 		kv488-3-presto.midi
 quicktest quickcheck:
 	./assert_barchecks.sh
+	./assert_consistent_marks.sh
 test check: quicktest
 	! $(MAKE) all -B PAPERSIZE=a4 2>&1 | grep -F -e err -e warn >&2
 	! $(MAKE) all -B PAPERSIZE=letter 2>&1 | grep -F -e err -e warn >&2

ftp/MozartWA/KV488/assert_consistent_marks.sh

@@ -0,0 +1,61 @@
+#!/bin/sh
+# We require that the ``\solo'' and ``\tutti'' marks be applied to
+# exactly the same measures for each instrument (within a given
+# movement). This script verifies that invariant.
+#
+# Originally written by William Chargin <[email protected]>. Released
+# under the MIT License.
+set -eu
+
+cd "$(dirname "$0")"
+
+failed=0
+
+# Find bar numbers on which a ``\solo'' or ``\tutti'' mark appears in
+# the LilyPond file given on standard input. Output is a
+# newline-delimited list of numbers.
+bar_numbers() {
+    grep -h -B 1 '\\solo\|\\tutti' \
+        | grep -F '\barNumberCheck' \
+        | sed -e 's/.*#\([0-9]\+\).*/\1/' \
+        | sort \
+        | uniq
+}
+
+# Check that ``\solo'' and ``\tutti'' marks are consistent within the
+# movement given by $1. If they are not, set the global `failed` to 1.
+check_movement() {
+    movement="$1"
+    canonical="${movement}"/piano.ily
+    expected="$(mktemp)"
+    actual="$(mktemp)"
+    bar_numbers <"${canonical}" >"${expected}"
+    for file in "${movement}"/*.ily; do
+        if ! grep -qF '\relative' "${file}"; then
+            # Not a piece of music.
+            continue
+        fi
+        bar_numbers <"${file}" >"${actual}"
+        if diff -q "${expected}" "${actual}" >/dev/null 2>/dev/null; then
+            continue
+        fi
+        # We add fake line numbers to be compatible with tools that
+        # expect "file:line: error" entries, such as Vim's quickfix
+        # list. It's not possible to get an accurate line number for
+        # missing marks, and it would be a bunch of extra work to get it
+        # for superfluous marks, so we just put everything on line 1.
+        comm -23 "${expected}" "${actual}" | sort -n | awk -v file="${file}" \
+            '{ printf("%s:1: missing %s\n", file, $1) }' >&2
+        comm -13 "${expected}" "${actual}" | sort -n | awk -v file="${file}" \
+            '{ printf("%s:1: superfluous %s\n", file, $1) }' >&2
+        failed=1
+    done
+    rm "${expected}" "${actual}"
+}
+
+main() {
+    check_movement 01_allegro
+    exit "${failed}"
+}
+
+main

ftp/MozartWA/KV488/create_makefile.sh

@@ -118,6 +118,7 @@ makefile() {
     printf '\n'
     printf 'quicktest quickcheck:\n'
     printf '\t%s\n' ./assert_barchecks.sh
+    printf '\t%s\n' ./assert_consistent_marks.sh
     printf 'test check: quicktest\n'
     # shellcheck disable=SC2016
     printf \