Fixing PHPStan level 4 issues

Author: gplanchat

.github/workflows/quality.yaml

@@ -33,5 +33,5 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           path: src/
-          level: 3
+          level: 4
           php_version: '8.2'

composer.lock

@@ -11,23 +11,23 @@
  */
 class GeneratorWrapper
 {
-    /** @param \Iterator<positive-int, Type> ...$iterators */
+    /** @param \Iterator<int<0, max>, Type> ...$iterators */
     public function rewind(\Iterator ...$iterators): void
     {
         foreach ($iterators as $iterator) {
             $iterator->rewind();
         }
     }
 
-    /** @param \Iterator<positive-int, Type> ...$iterators */
+    /** @param \Iterator<int<0, max>, Type> ...$iterators */
     public function next(\Iterator ...$iterators): void
     {
         foreach ($iterators as $iterator) {
             $iterator->next();
         }
     }
 
-    /** @param \Iterator<positive-int, Type> ...$iterators */
+    /** @param \Iterator<int<0, max>, Type> ...$iterators */
     public function valid(\Iterator ...$iterators): bool
     {
         foreach ($iterators as $iterator) {
@@ -41,7 +41,7 @@ public function valid(\Iterator ...$iterators): bool
 
     /**
      * @param Type $value
-     * @param \Generator<positive-int, ResultBucketInterface<Type>, Type, void> ...$generators
+     * @param \Generator<int<0, max>, ResultBucketInterface<Type>, Type, void> ...$generators
      */
     public function send($value, \Generator ...$generators): \Generator
     {

src/GeneratorWrapper.php

@@ -21,7 +21,7 @@ public function __construct(private LoggerInterface $logger, private string $log
     {
     }
 
-    /** @return \Generator<positive-int, AcceptanceResultBucket<Type>|EmptyResultBucket, Type|null, void> */
+    /** @return \Generator<int<0, max>, AcceptanceResultBucket<Type>|EmptyResultBucket, Type|null, void> */
     public function load(): \Generator
     {
         $line = yield new EmptyResultBucket();

src/Loader/LogLoader.php

@@ -28,7 +28,7 @@ public function __construct($stream)
         $this->stream = $stream;
     }
 
-    /** @return \Generator<positive-int, AcceptanceResultBucket<Type>|EmptyResultBucket, Type|null, void> */
+    /** @return \Generator<int<0, max>, AcceptanceResultBucket<Type>|EmptyResultBucket, Type|null, void> */
     public function load(): \Generator
     {
         $line = yield new EmptyResultBucket();

src/Loader/StreamLoader.php

@@ -22,9 +22,9 @@
 
 class Pipeline implements PipelineInterface, WalkableInterface, RunnableInterface
 {
-    /** @var \AppendIterator<positive-int, non-empty-array<array-key, mixed>|object, \Iterator<positive-int, non-empty-array<array-key, mixed>|object>> */
+    /** @var \AppendIterator<int<0, max>, non-empty-array<array-key, mixed>|object, \Iterator<int<0, max>, non-empty-array<array-key, mixed>|object>> */
     private readonly \AppendIterator $source;
-    /** @var \Iterator<positive-int, non-empty-array<array-key, mixed>|object>|\NoRewindIterator */
+    /** @var \Iterator<int<0, max>, non-empty-array<array-key, mixed>|object>|\NoRewindIterator */
     private iterable $subject;
 
     public function __construct(

src/Pipeline.php

@@ -30,11 +30,11 @@ public function __construct(
      * @template InputType of non-empty-array<array-key, mixed>|object
      * @template OutputType of non-empty-array<array-key, mixed>|object
      *
-     * @param \Iterator<positive-int, InputType|null> $source
-     * @param \Generator<positive-int, ResultBucketInterface<OutputType>|AcceptanceResultBucketInterface<InputType>|RejectionResultBucketInterface<InputType>|null, InputType, void> $coroutine
+     * @param \Iterator<int<0, max>, InputType|null> $source
+     * @param \Generator<int<0, max>, ResultBucketInterface<OutputType>|AcceptanceResultBucketInterface<InputType>|RejectionResultBucketInterface<InputType>|null, InputType, void> $coroutine
      * @param StepRejectionInterface<InputType> $rejection
      * @param StepStateInterface $state
-     * @return \Iterator<positive-int, ResultBucketInterface<OutputType>>
+     * @return \Iterator<int<0, max>, ResultBucketInterface<OutputType>>
      */
     public function run(
         \Iterator $source,

src/PipelineRunner.php

@@ -19,7 +19,7 @@
  */
 class BatchingTransformer implements TransformerInterface, FlushableInterface
 {
-    /** @var array<array-key, InputType> */
+    /** @var list<InputType> */
     private array $batch = [];
 
     /**
@@ -30,7 +30,7 @@ public function __construct(
     ) {
     }
 
-    /** @return \Generator<positive-int, ResultBucketInterface<OutputType>|EmptyResultBucket, InputType|null, void> */
+    /** @return \Generator<int<0, max>, ResultBucketInterface<OutputType>|EmptyResultBucket, InputType|null, void> */
     public function transform(): \Generator
     {
         $this->batch = [];

src/Transformer/BatchingTransformer.php

@@ -29,7 +29,7 @@ public function __construct(
     }
 
     /**
-     * @return \Generator<positive-int, AcceptanceResultBucket<OutputType>|EmptyResultBucket, InputType|null, void>
+     * @return \Generator<int<0, max>, AcceptanceResultBucket<OutputType>|EmptyResultBucket, InputType|null, void>
      */
     public function transform(): \Generator
     {

src/Transformer/CallableTransformer.php

@@ -22,7 +22,7 @@ public function __construct(
     ) {
     }
 
-    /** @return \Generator<positive-int, AcceptanceResultBucket<OutputType>|EmptyResultBucket, InputType|null, void> */
+    /** @return \Generator<int<0, max>, AcceptanceResultBucket<OutputType>|EmptyResultBucket, InputType|null, void> */
     public function transform(): \Generator
     {
         $line = yield new EmptyResultBucket();