add_reader/add_writer/remove_writer crash when using not using Pycopy, as otherwise required by README

[ernstnaezer]

Hi,

not sure if this belongs in Picoweb or in uasyncio - but when I try to run the example webserver I get the following crashlog:

Traceback (most recent call last):
  File "main.py", line 30, in <module>
  File "/lib/picoweb/__init__.py", line 298, in run
  File "/lib/uasyncio/core.py", line 155, in run_forever
  File "/lib/uasyncio/core.py", line 130, in run_forever
  File "/lib/uasyncio/__init__.py", line 60, in remove_writer
  TypeError: function takes 2 positional arguments but 3 were given

The webserver code isn't anything special, just wait for WiFi and host an app; both a route and a static folder.

I tried upip.install as well as copy & past the latest Picoweb, uasyncio & uasyncio.core from the Github repos.

[pfalcon]

The traceback you posted is cut off, and doesn't show what error happens. But likely, you need to use https://github.com/pfalcon/pycopy , as the README suggests.

[ernstnaezer]

It's mentioned in this commit - upgrade to your fork as you suggestion. I'll have a look tomorrow and this issue can probably be closed.

pfalcon/pycopy-lib@4f70217#diff-c502b73effb6927190c86fdaab27ee84

---

The traceback you posted is cut off, and doesn't show what error happens.

Ah yes, sorry! Fixed in the original description. I'll give your suggestion a try to see if that fixes the issue.

Dug a little further and it seems to go wrong on the last line of remove_writer:

    def remove_writer(self, sock):
        if DEBUG and __debug__:
            log.debug("remove_writer(%s)", sock)
        self.objmap.pop(id(sock), None)
        # StreamWriter.awrite() first tries to write to a socket,
        # and if that succeeds, yield IOWrite may never be called
        # for that socket, and it will never be added to poller. So,
        # ignore such error.
        self.poller.unregister(sock, False)

The self.poller.unregister takes 2 arguments: sock & False.

I think the function definition that implements that method lives in extmod/moduselect.c (file), and it reads:

STATIC mp_obj_t poll_unregister(mp_obj_t self_in, mp_obj_t obj_in)

If I remove the False from the python function call, the crash is gone.

Will keep looking

[larsrinn]

I can confirm the issue and also that it's gone when applying @ernstnaezer's fix

[pfalcon]

it seems to go wrong on the last line of remove_writer:

It doesn't go wrong, it goes right. That's a recent fix applied for uasyncio to work under different circumstances, and efficiently in all cases: pfalcon/pycopy-lib@4f70217 . (Efficiency is the primary goal of uasyncio, there're no compromises here.)

Once again, that requires up to date Pycopy, from https://github.com/pfalcon/pycopy , as specified in the README. Corresponding patch was submitted upstream long ago too: micropython/micropython#4217

[traverseda]

I just built micropython from git using the AUR and this error still seems to be there? Using the non-git version I don't have access to ussl, so I don't have upip.

I can chalk a certain amount up to just archlinux weirdness, I suppose that's just a problem with source packages sometimes. But still, it's odd.

[pfalcon]

People writing, or intended to write, here should instead go to micropython/micropython#4217 and let the maintainers of that repo know that that unmerged patch causes them unneeded complications.

[fgiava]

Hi,
I’ll try to write here because I think the problem that I'm having using Picoweb is similar to that described in this thread.

My test is done on the ESP32 module and I’m using the uPithon ver. 1.11 with the Picoweb and Uasyncio Ulogging, taken from pfalcon/Picoweb and pfalcon/pcopy-lib. As soon as I lunch the webserver example I have this output:

exec(open('./picoTest.py').read(),globals())
[0;32mI (81912) modsocket: Initializing [0m
Running on picoweb/, in run_fo "/lib/uasyncio/init.py", line 31, in add_reader
TypeError: function expected at most 3 arguments, got 4

At line 31 of uasyncio we have:
self.poller.register(sock, select.POLLIN, cb)

I’d like to try to build the Pcopy executable but I think that it is a bit over my head; thank you in advance for any suggestion.

[pfalcon]

The suggestion is to read README: https://github.com/pfalcon/picoweb/blob/master/README.rst, which states clearly that yes, Pycopy (https://github.com/pfalcon/pycopy) is required for Picoweb, as Picoweb is part of the Pycopy project (https://github.com/topics/pycopy).