Skip to content

Commit d92b070

Browse files
committed
Fix nits
1 parent ca0d70e commit d92b070

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

cmake/cmake/ConfigureChecks.cmake

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,10 @@ check_struct_has_member(
239239
)
240240
set(HAVE_STRUCT_STAT_ST_RDEV ${PHP_HAVE_STRUCT_STAT_ST_RDEV})
241241

242-
check_struct_has_member(
243-
"struct flock"
244-
l_type
245-
fcntl.h
246-
PHP_HAVE_STRUCT_FLOCK
247-
)
248-
set(HAVE_STRUCT_FLOCK ${PHP_HAVE_STRUCT_FLOCK})
242+
cmake_push_check_state(RESET)
243+
set(CMAKE_EXTRA_INCLUDE_FILES "fcntl.h")
244+
check_type_size("struct flock" STRUCT_FLOCK) # Defines HAVE_STRUCT_FLOCK
245+
cmake_pop_check_state()
249246

250247
# Check for sockaddr_storage and sockaddr.sa_len.
251248
cmake_push_check_state(RESET)
@@ -349,7 +346,7 @@ cmake_push_check_state(RESET)
349346
if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
350347
list(APPEND CMAKE_EXTRA_INCLUDE_FILES ws2tcpip.h)
351348
endif()
352-
check_type_size("socklen_t" SOCKLEN_T)
349+
check_type_size("socklen_t" SOCKLEN_T) # Defines HAVE_SOCKLEN_T
353350
cmake_pop_check_state()
354351

355352
################################################################################

cmake/cmake/platforms/Windows.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
6565
set(HAVE_SOCKLEN_T TRUE)
6666
set(HAVE_STDDEF_H TRUE) # Defined by check_type_size().
6767
set(HAVE_STDINT_H TRUE) # Defined by check_type_size().
68+
set(HAVE_STRUCT_FLOCK FALSE)
69+
set(HAVE_SYS_TYPES_H TRUE) # Defined by check_type_size().
6870
set(HAVE_WS2TCPIP_H TRUE)
6971
set(PHP_EXT_FILEINFO_HAVE_STRCASESTR FALSE)
7072
set(PHP_EXT_FILEINFO_HAVE_STRNDUP FALSE)
@@ -205,7 +207,6 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
205207
set(PHP_HAVE_STRINGS_H FALSE)
206208
set(PHP_HAVE_STRLCAT FALSE)
207209
set(PHP_HAVE_STRLCPY FALSE)
208-
set(PHP_HAVE_STRUCT_FLOCK FALSE)
209210
set(PHP_HAVE_STRUCT_SOCKADDR_SA_LEN FALSE)
210211
set(PHP_HAVE_STRUCT_STAT_ST_BLKSIZE FALSE)
211212
set(PHP_HAVE_STRUCT_STAT_ST_BLOCKS FALSE)

0 commit comments

Comments
 (0)