From 882760e93cb37722b6495793bc439b1d5c6df643 Mon Sep 17 00:00:00 2001 From: Lazizbek Ergashev Date: Fri, 21 Aug 2026 18:29:47 +0500 Subject: [PATCH 1/2] fix: exit code with --shard and --parallel --- src/Plugins/Shard.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Plugins/Shard.php b/src/Plugins/Shard.php index 7c7a29cc6..db5cf916e 100644 --- a/src/Plugins/Shard.php +++ b/src/Plugins/Shard.php @@ -132,7 +132,14 @@ public function handleArguments(array $arguments): array $this->ensureFilterLengthIsSafe($filter); - return [...$arguments, '--filter', $filter]; + $arguments = [...$arguments, '--filter', $filter]; + + if ($this->hasArgument('--do-not-fail-on-empty-test-suite', $arguments) + || $this->hasArgument('--fail-on-empty-test-suite', $arguments)) { + return $arguments; + } + + return [...$arguments, '--do-not-fail-on-empty-test-suite']; } /** From 54f4a1de1104ae435f921071cfbb7c3a76026644 Mon Sep 17 00:00:00 2001 From: Lazizbek Ergashev Date: Fri, 21 Aug 2026 18:33:52 +0500 Subject: [PATCH 2/2] fix: match existing argument-handling style in Shard --- src/Plugins/Shard.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Plugins/Shard.php b/src/Plugins/Shard.php index db5cf916e..d41213e55 100644 --- a/src/Plugins/Shard.php +++ b/src/Plugins/Shard.php @@ -134,12 +134,11 @@ public function handleArguments(array $arguments): array $arguments = [...$arguments, '--filter', $filter]; - if ($this->hasArgument('--do-not-fail-on-empty-test-suite', $arguments) - || $this->hasArgument('--fail-on-empty-test-suite', $arguments)) { + if ($this->hasArgument('--do-not-fail-on-empty-test-suite', $arguments) || $this->hasArgument('--fail-on-empty-test-suite', $arguments)) { return $arguments; } - return [...$arguments, '--do-not-fail-on-empty-test-suite']; + return $this->pushArgument('--do-not-fail-on-empty-test-suite', $arguments); } /**