Skip to content

K8SPXC-1748: add checks before creating functions in collector #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+330 −270
Open

K8SPXC-1748: add checks before creating functions in collector #2264

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12537a1
K8SPXC-1748: add checks before creating functions in collector
pooknull Nov 21, 2025
a292563
create functions in the entrypoint
pooknull Nov 24, 2025
e9d086f
`CREATE FUNCTION` should be executed only on 8.0 ver
pooknull Nov 25, 2025
7a14d1b
temporarily set `wsrep_on = OFF`
pooknull Nov 25, 2025
7f3588a
Merge branch 'main' into K8SPXC-1748
hors Nov 25, 2025
0f86adc
check for functions in 8.4 too
pooknull Nov 27, 2025
5484528
Merge branch 'main' into K8SPXC-1748
pooknull Nov 27, 2025
d827e83
update version-service file for smart update tests
pooknull Dec 1, 2025
6233eb6
create functions earlier
pooknull Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions build/pxc-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,12 @@ if [ -z "$CLUSTER_JOIN" ] && [ "$1" = 'mysqld' ] && [ -z "$wantHelp" ]; then
fi
set -x

echo "CREATE FUNCTION IF NOT EXISTS get_last_record_timestamp_by_binlog RETURNS INTEGER SONAME 'binlog_utils_udf.so'" | "${mysql[@]}"

echo "CREATE FUNCTION IF NOT EXISTS get_gtid_set_by_binlog RETURNS STRING SONAME 'binlog_utils_udf.so'" | "${mysql[@]}"

echo "CREATE FUNCTION IF NOT EXISTS get_first_record_timestamp_by_binlog RETURNS INTEGER SONAME 'binlog_utils_udf.so'" | "${mysql[@]}"
Copy link
Contributor

@egegunes egegunes Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see a lot of test failures with the error full cluster crash detected. probably these statements are the reason. also do we have these in mysql 5.7?

Copy link
Contributor Author

@pooknull pooknull Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e9d086f


echo
ls /docker-entrypoint-initdb.d/ >/dev/null
for f in /docker-entrypoint-initdb.d/*; do
Expand Down
28 changes: 18 additions & 10 deletions cmd/pitr/pxc/pxc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,19 +351,27 @@ func (p *PXC) UninstallBinlogUDFComponent(ctx context.Context) error {
}

func (p *PXC) CreateCollectorFunctions(ctx context.Context) error {
_, err := p.db.ExecContext(ctx, "CREATE FUNCTION IF NOT EXISTS get_last_record_timestamp_by_binlog RETURNS INTEGER SONAME 'binlog_utils_udf.so'")
if err != nil {
return errors.Wrap(err, "create function get_first_record_timestamp_by_binlog")
m := map[string]string{
"get_last_record_timestamp_by_binlog": "INTEGER",
"get_gtid_set_by_binlog": "STRING",
"get_first_record_timestamp_by_binlog": "INTEGER",
}

_, err = p.db.ExecContext(ctx, "CREATE FUNCTION IF NOT EXISTS get_gtid_set_by_binlog RETURNS STRING SONAME 'binlog_utils_udf.so'")
if err != nil {
return errors.Wrap(err, "create function get_gtid_set_by_binlog")
}
for functionName, returnType := range m {
var x int
err := p.db.QueryRowContext(ctx, `SELECT 1 FROM mysql.func WHERE name = ? LIMIT 1`, functionName).Scan(&x)
if err != nil && !errors.Is(err, sql.ErrNoRows) {
return errors.Wrapf(err, "check if function %s exists", functionName)
}
if err == nil {
log.Printf("function %s already exists", functionName)
continue
}
Comment on lines +363 to +370
Copy link
Contributor

@gkech gkech Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are using the IF NOT EXISTS on the subsequent query, is this check regarding the existence of the function necessary?

Copy link
Contributor

@egegunes egegunes Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the whole point. CREATE IF NOT EXISTS still counts as DDL


_, err = p.db.ExecContext(ctx, "CREATE FUNCTION IF NOT EXISTS get_first_record_timestamp_by_binlog RETURNS INTEGER SONAME 'binlog_utils_udf.so'")
if err != nil {
return errors.Wrap(err, "create function get_first_record_timestamp_by_binlog")
createQ := fmt.Sprintf("CREATE FUNCTION IF NOT EXISTS %s RETURNS %s SONAME 'binlog_utils_udf.so'", functionName, returnType)
Copy link
Contributor

@egegunes egegunes Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to wrap this with SET SESSION wsrep_on = OFF; and SET SESSION wsrep_on = ON;

Copy link
Contributor Author

@pooknull pooknull Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7a14d1b

if _, err := p.db.ExecContext(ctx, createQ); err != nil {
return errors.Wrapf(err, "create function %s", functionName)
}
}

return nil
Expand Down
12 changes: 12 additions & 0 deletions e2e-tests/pitr/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,18 @@ main() {
cluster="pitr"
spinup_pxc "$cluster" "$test_dir/conf/$cluster.yml"

pitr_pod=$(
kubectl_bin get pods \
--selector="app.kubernetes.io/component=pitr" \
-o 'jsonpath={.items[].metadata.name}'
)
wait_pod "$pitr_pod"
function_exists_count=$(kubectl_bin logs -l "app.kubernetes.io/component=pitr" --tail=-1 2>/dev/null | grep -c 'already exists')
if [ "$function_exists_count" -eq 0 ]; then
echo "There are no 'function ... already exists' logs"
exit 1
fi

run_backup "$cluster" "on-pitr-minio"

# Temporarily skipping this check
Expand Down
Loading