PMM-14560: Improve theme switching synchronization #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitri-saricev-3pillargloball
requested review from
YashSartanpara1 and
matejkubinec
- Publish ThemeChangedEvent after CSS loads for better sync - Subscribe to ThemeChangedEvent in SharedPreferences dropdown - Add CSS load error handling to prevent stuck UI state - Fix TypeScript types to use GrafanaTheme2 properly Fixes visual lag between theme dropdown and content rendering.
dmitri-saricev-3pillargloball
force-pushed
the
PMM-14560-Bug-change-theme
branch
from
0b48fd3 to
3a133bc
Compare
public/app/core/components/SharedPreferences/SharedPreferences.tsx
Outdated
Show resolved
Hide resolved
public/app/core/components/SharedPreferences/SharedPreferences.test.tsx
Outdated
Show resolved
Hide resolved
public/app/core/components/SharedPreferences/SharedPreferences.test.tsx
Outdated
Show resolved
Hide resolved
- Fixed all tests (12/12 passing) - Added @percona comments as requested by Matej - Fixed test structure to use proper GrafanaTheme2 format - Added proper test cleanup and act() wrappers
matejkubinec
reviewed
Dec 1, 2025
matejkubinec
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PMM-14560
Fixes visual lag between theme dropdown and content rendering.
What is this feature?
[Add a brief description of what the feature or update does.]
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
https://github.com/user-attachments/assets/88dc5014-8ed4-4bdf-9fb9-0320a8291a60
Special notes for your reviewer:
FB:
Percona-Lab/pmm-submodules#4131
https://pmm.cd.percona.com/blue/organizations/jenkins/pmm3-submodules/detail/pmm3-submodules/1990/pipeline/
Please check that: