From 4cccf8f1f4385c788e81b3ab044a2778a1ed83f5 Mon Sep 17 00:00:00 2001 From: Ben Campbell Date: Thu, 13 Feb 2025 10:16:51 +0000 Subject: [PATCH 1/2] Dont use -a on passwd for empty password checks --- unix-privesc-check | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/unix-privesc-check b/unix-privesc-check index c5942ee..ee734ba 100755 --- a/unix-privesc-check +++ b/unix-privesc-check @@ -778,14 +778,14 @@ fi if [ -r "$SHADOW" ]; then echo "Checking for accounts with no passwords" if [ "$OS" = "linux" ]; then - passwd -S -a | while read LINE + while read LINE do - USER=`echo "$LINE" | awk '{print $1}'` - STATUS=`echo "$LINE" | awk '{print $2}'` + USERNAME=`echo "$LINE" | cut -f 1 -d ":"` + STATUS=`passwd -s $USERNAME | awk '{print $2}'` if [ "$STATUS" = "NP" ]; then - echo "[UPC015] WARNING: User $USER doesn't have a password" + echo "[UPC015] WARNING: User $USERNAME doesn't have a password" fi - done + done < $SHADOW elif [ "$OS" = "solaris" ]; then passwd -s -a | while read LINE do From 0a164a3dd17d3b269bfacb26c976b7edeab024b2 Mon Sep 17 00:00:00 2001 From: Ben Campbell Date: Thu, 13 Feb 2025 10:23:55 +0000 Subject: [PATCH 2/2] Capital argument --- unix-privesc-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unix-privesc-check b/unix-privesc-check index ee734ba..22aae4c 100755 --- a/unix-privesc-check +++ b/unix-privesc-check @@ -781,7 +781,7 @@ if [ -r "$SHADOW" ]; then while read LINE do USERNAME=`echo "$LINE" | cut -f 1 -d ":"` - STATUS=`passwd -s $USERNAME | awk '{print $2}'` + STATUS=`passwd -S $USERNAME | awk '{print $2}'` if [ "$STATUS" = "NP" ]; then echo "[UPC015] WARNING: User $USERNAME doesn't have a password" fi