Skip to content

Remove public From<String> implementations from FFI error wrappers #1117

@spacebear21

Description

@spacebear21

Following up on #737, there are three remaining FFI error types that implement From<String>: PjParseError, PjNotSupported and OhttpError.

Ideally these types should just wrap the inner payjoin error instead of using a custom msg: String inner value. If that's not possible due to complex inner types, at the very least we should use map_err instead of exposing From<String> in the public API.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions