Skip to content

Conversation

@rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Jun 5, 2025

  • Upgraded dependencies for test runner because it was no longer working - version 2 is deprecated

  • Added React19 support

  • Removed generated files from git and added to .gitignore

  • Checked with 19 and it builds but gets docs error as expected

  • 18 builds and works

  • 17 builds but there are some React errors

WARNING in ../../node_modules/@patternfly/react-core/dist/esm/components/Card/CardHeader.js 15:21-32
export 'useId' (imported as 'React') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)
WARNING in ../../node_modules/@patternfly/react-core/dist/esm/components/DataList/DataListCheck.js 8:21-32
export 'useId' (imported as 'React') was not found in 'react' (possible exports: Children, Component, Fragment, Profiler, PureComponent, StrictMode, Suspense, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cloneElement, createContext, createElement, createFactory, createRef, forwardRef, isValidElement, lazy, memo, useCallback, useContext, useDebugValue, useEffect, useImperativeHandle, useLayoutEffect, useMemo, useReducer, useRef, useState, version)

I checked against main branch and it has similar errors there. useId was introduced in React 18, so that's probably been broken for a while. Unsure if we want to open a follow-up issue or shrug since no one has complained about React 17 support being broken.

@rebeccaalpert rebeccaalpert linked an issue Jun 5, 2025 that may be closed by this pull request
2 tasks
@rebeccaalpert rebeccaalpert changed the title Draft: feat(React19): Add support for React19 feat(React19): Add support for React19 Jun 5, 2025
@rebeccaalpert rebeccaalpert force-pushed the react19 branch 4 times, most recently from cb79798 to 2a6071c Compare June 5, 2025 20:26
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with leaving the v17 warnings until its requested, since this extension is deprecated and this would have been an old bug.

@rebeccaalpert rebeccaalpert merged commit 1558f1f into patternfly:main Jun 17, 2025
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

virtualized - react 19 support

3 participants