Skip to content

Sass styles not referenced in examples #72

@evwilkin

Description

@evwilkin

This package contains a /sass directory with the component styles but these are compiled directly to the dist/css directory and not referenced by the examples.

Instead, the styles are mostly duplicated in separate CSS files alongside the examples themselves and there is no concrete connection between the styles shipped with the package vs. the styles referenced in the examples, which has caused inconsistencies between the two such as the vertical tabs spacing in the package code (left) vs. example styles (right):

Ideally this sass code should be converted into css that can be passed to the patternfly-docs build which should apply the styles to the example code by default, and then separately copied into the dist directory, somewhat similar to this change in react-user-feedback (except that sass file was just changed directly to css).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    PR Review

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions