Skip to content

Commit fbd1d32

Browse files
committed
feat(CC-batch-4): group review 5 updates
1 parent fe176ef commit fbd1d32

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

packages/code-connect/components/DataList/_1BuildItYourselfBasicRows.figma.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ figma.connect(
99
children: figma.children('*')
1010
},
1111
example: (props) => (
12+
// aria-labelledby should point to an ID within the DataListItemRow/DataListItemCell
1213
<DataListItem aria-labelledby="child-text-id">
1314
<DataListItemRow rowid="<row-id>">{props.children}</DataListItemRow>
1415
</DataListItem>

packages/code-connect/components/DataList/_1BuildItYourselfClickableRows.figma.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ figma.connect(
1111
children: figma.children('*')
1212
},
1313
example: (props) => (
14-
<DataListItem aria-labelledby="child text id">
14+
// aria-labelledby should point to an ID within the DataListItemRow/DataListItemCell
15+
<DataListItem aria-labelledby="child-text-id">
1516
<DataListItemRow rowid="<row-id>">{props.children}</DataListItemRow>
1617
</DataListItem>
1718
)

packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ figma.connect(
88
'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=21279-116342',
99
{
1010
props: {
11-
options: 'see example for tree data'
11+
options:
12+
'refer to patternfly documentation example for tree data https://www.patternfly.org/components/dual-list-selector#with-tree'
1213
},
1314
example: (props) => (
1415
<DualListSelectorList>

0 commit comments

Comments
 (0)